From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: chunkuang.hu@kernel.org
Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, matthias.bgg@gmail.com, ck.hu@mediatek.com,
jitao.shi@mediatek.com, jie.qiu@mediatek.com,
junzhi.zhao@mediatek.com, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com,
dmitry.baryshkov@linaro.org, lewis.liao@mediatek.com,
ives.chenjh@mediatek.com, tommyyl.chen@mediatek.com,
jason-jh.lin@mediatek.com
Subject: Re: [PATCH v9 17/23] drm/mediatek: mtk_hdmi: Split driver and add common probe function
Date: Tue, 15 Apr 2025 12:48:25 +0200 [thread overview]
Message-ID: <bc094a07-2a4c-4048-8c15-b096db62f142@collabora.com> (raw)
In-Reply-To: <20250415104321.51149-18-angelogioacchino.delregno@collabora.com>
Il 15/04/25 12:43, AngeloGioacchino Del Regno ha scritto:
> In preparation for adding a new driver for the HDMI TX v2 IP,
> split out the functions that will be common between the already
> present mtk_hdmi (v1) driver and the new one.
>
> Since the probe flow for both drivers is 90% similar, add a common
> probe function that will be called from each driver's .probe()
> callback, avoiding lots of code duplication.
>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 11 +-
> drivers/gpu/drm/mediatek/Makefile | 1 +
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 538 +-----
> drivers/gpu/drm/mediatek/mtk_hdmi.c.orig | 1769 ++++++++++++++++++++
> drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 422 +++++
> drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 188 +++
> 6 files changed, 2398 insertions(+), 531 deletions(-)
> create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi.c.orig
CK, I just acknowledged that a .orig file slipped through and got sent out with
this patch....
Truly sorry for that, can you please fix that up while applying without having me
send another patchbomb?
Many thanks,
Angelo
> create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_common.h
>
next prev parent reply other threads:[~2025-04-15 10:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 10:42 [PATCH v9 00/23] Add support for MT8195/88 HDMIv2 and DDCv2 AngeloGioacchino Del Regno
2025-04-15 10:42 ` [PATCH v9 01/23] dt-bindings: display: mediatek: Add binding for HDMIv2 DDC AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 02/23] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2 AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 03/23] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 04/23] drm/mediatek: mtk_cec: Switch to register as module_platform_driver AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 05/23] drm/mediatek: mtk_hdmi_ddc: " AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 06/23] drm/mediatek: mtk_hdmi: Convert to module_platform_driver macro AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 07/23] drm/mediatek: hdmi: Use regmap instead of iomem for main registers AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 08/23] drm/mediatek: mtk_hdmi: Disgregate function mtk_hdmi_audio_set_param() AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 09/23] drm/mediatek: mtk_hdmi: Move audio params selection to new function AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 10/23] drm/mediatek: mtk_hdmi: Move plugged_cb/codec_dev setting " AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 11/23] drm/mediatek: mtk_hdmi: Move N/CTS " AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 12/23] drm/mediatek: mtk_hdmi: Use dev_err_probe() in mtk_hdmi_dt_parse_pdata() AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 13/23] drm/mediatek: mtk_hdmi: Move CEC device parsing in new function AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 14/23] drm/mediatek: mtk_hdmi: Move output init to mtk_hdmi_register_audio_driver() AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 15/23] drm/mediatek: mtk_hdmi: Improve mtk_hdmi_get_all_clk() flexibility AngeloGioacchino Del Regno
2025-04-21 14:10 ` Chun-Kuang Hu
2025-04-15 10:43 ` [PATCH v9 16/23] drm/mediatek: mtk_hdmi: Add HDMI IP version configuration to pdata AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 17/23] drm/mediatek: mtk_hdmi: Split driver and add common probe function AngeloGioacchino Del Regno
2025-04-15 10:48 ` AngeloGioacchino Del Regno [this message]
2025-04-16 6:44 ` CK Hu (胡俊光)
2025-04-16 8:36 ` AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 18/23] drm/mediatek: mtk_hdmi_common: Make CEC support optional AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 19/23] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 20/23] drm/mediatek: mtk_hdmi_common: Add OP_HDMI if helper funcs assigned AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 21/23] drm/mediatek: mtk_hdmi_common: Add var to enable interlaced modes AngeloGioacchino Del Regno
2025-04-15 10:43 ` [PATCH v9 22/23] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188 AngeloGioacchino Del Regno
2025-04-21 19:16 ` Dmitry Baryshkov
2025-04-22 13:53 ` AngeloGioacchino Del Regno
2025-04-22 14:16 ` Dmitry Baryshkov
2025-04-15 10:43 ` [PATCH v9 23/23] drm/mediatek: mtk_hdmi_v2: Add debugfs ops and implement ABIST AngeloGioacchino Del Regno
2025-08-02 22:23 ` [PATCH v9 00/23] Add support for MT8195/88 HDMIv2 and DDCv2 Dmitry Baryshkov
2025-08-04 7:50 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc094a07-2a4c-4048-8c15-b096db62f142@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ives.chenjh@mediatek.com \
--cc=jason-jh.lin@mediatek.com \
--cc=jie.qiu@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=junzhi.zhao@mediatek.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=lewis.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tommyyl.chen@mediatek.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox