* [PATCH] xen: Change xen-acpi-processor dom0 dependency
@ 2025-03-31 17:29 Jason Andryuk
2025-04-02 14:24 ` Jürgen Groß
0 siblings, 1 reply; 4+ messages in thread
From: Jason Andryuk @ 2025-03-31 17:29 UTC (permalink / raw)
To: Juergen Gross, Stefano Stabellini, Oleksandr Tyshchenko
Cc: Penny Zheng, Jason Andryuk, Jan Beulich, xen-devel, linux-kernel
xen-acpi-processor functions under a PVH dom0 with only a
xen_initial_domain() runtime check. Change the Kconfig dependency from
PV dom0 to generic dom0 to reflect that.
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
---
drivers/xen/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index f7d6f47971fd..24f485827e03 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
config XEN_ACPI_PROCESSOR
tristate "Xen ACPI processor"
- depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
+ depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
default m
help
This ACPI processor uploads Power Management information to the Xen
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: Change xen-acpi-processor dom0 dependency
2025-03-31 17:29 [PATCH] xen: Change xen-acpi-processor dom0 dependency Jason Andryuk
@ 2025-04-02 14:24 ` Jürgen Groß
2025-04-02 14:34 ` Jason Andryuk
2025-04-03 7:08 ` Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Jürgen Groß @ 2025-04-02 14:24 UTC (permalink / raw)
To: Jason Andryuk, Stefano Stabellini, Oleksandr Tyshchenko
Cc: Penny Zheng, Jan Beulich, xen-devel, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1073 bytes --]
On 31.03.25 19:29, Jason Andryuk wrote:
> xen-acpi-processor functions under a PVH dom0 with only a
> xen_initial_domain() runtime check. Change the Kconfig dependency from
> PV dom0 to generic dom0 to reflect that.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
> ---
> drivers/xen/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index f7d6f47971fd..24f485827e03 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
>
> config XEN_ACPI_PROCESSOR
> tristate "Xen ACPI processor"
> - depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
> + depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
> default m
> help
> This ACPI processor uploads Power Management information to the Xen
Assuming that all needed hypercalls are fine for PVH dom0:
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: Change xen-acpi-processor dom0 dependency
2025-04-02 14:24 ` Jürgen Groß
@ 2025-04-02 14:34 ` Jason Andryuk
2025-04-03 7:08 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Jason Andryuk @ 2025-04-02 14:34 UTC (permalink / raw)
To: Jürgen Groß, Stefano Stabellini, Oleksandr Tyshchenko
Cc: Penny Zheng, Jan Beulich, xen-devel, linux-kernel
On 2025-04-02 10:24, Jürgen Groß wrote:
> On 31.03.25 19:29, Jason Andryuk wrote:
>> xen-acpi-processor functions under a PVH dom0 with only a
>> xen_initial_domain() runtime check. Change the Kconfig dependency from
>> PV dom0 to generic dom0 to reflect that.
>>
>> Suggested-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
>> ---
>> drivers/xen/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index f7d6f47971fd..24f485827e03 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
>> config XEN_ACPI_PROCESSOR
>> tristate "Xen ACPI processor"
>> - depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>> + depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>> default m
>> help
>> This ACPI processor uploads Power Management information to
>> the Xen
>
> Assuming that all needed hypercalls are fine for PVH dom0:
It's platform_op XENPF_set_processor_pminfo and XENPF_get_cpuinfo. Xen
doesn't check if the caller is PV or PVH.
> Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks, Juergen.
-Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: Change xen-acpi-processor dom0 dependency
2025-04-02 14:24 ` Jürgen Groß
2025-04-02 14:34 ` Jason Andryuk
@ 2025-04-03 7:08 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2025-04-03 7:08 UTC (permalink / raw)
To: Jürgen Groß
Cc: Penny Zheng, xen-devel, linux-kernel, Jason Andryuk,
Stefano Stabellini, Oleksandr Tyshchenko
On 02.04.2025 16:24, Jürgen Groß wrote:
> On 31.03.25 19:29, Jason Andryuk wrote:
>> xen-acpi-processor functions under a PVH dom0 with only a
>> xen_initial_domain() runtime check. Change the Kconfig dependency from
>> PV dom0 to generic dom0 to reflect that.
>>
>> Suggested-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
>> ---
>> drivers/xen/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index f7d6f47971fd..24f485827e03 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
>>
>> config XEN_ACPI_PROCESSOR
>> tristate "Xen ACPI processor"
>> - depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>> + depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>> default m
>> help
>> This ACPI processor uploads Power Management information to the Xen
>
> Assuming that all needed hypercalls are fine for PVH dom0:
If you want to feel further ascertained, you could also add
Tested-by: Jan Beulich <jbeulich@suse.com>
even if that was only in the context of "xen/acpi: upload power and
performance related data from a PVH dom0", where I noticed this issue.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-03 7:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-31 17:29 [PATCH] xen: Change xen-acpi-processor dom0 dependency Jason Andryuk
2025-04-02 14:24 ` Jürgen Groß
2025-04-02 14:34 ` Jason Andryuk
2025-04-03 7:08 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox