* [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA
@ 2014-02-21 19:54 Geert Uytterhoeven
2014-02-21 20:27 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-02-21 19:54 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Laurent Pinchart
Cc: linux-mtd, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mtd/nand/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 90ff447bf043..e7786913280a 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -458,6 +458,7 @@ config MTD_NAND_MXC
config MTD_NAND_SH_FLCTL
tristate "Support for NAND on Renesas SuperH FLCTL"
+ depends on HAS_DMA
depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
help
Several Renesas SuperH CPU has FLCTL. This option enables support
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA
2014-02-21 19:54 [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA Geert Uytterhoeven
@ 2014-02-21 20:27 ` Laurent Pinchart
2014-02-21 20:49 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-02-21 20:27 UTC (permalink / raw)
To: Geert Uytterhoeven, linux-mtd; +Cc: David Woodhouse, Brian Norris, linux-kernel
Hi Geert,
Thank you for the patch.
On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
> sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
> sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/mtd/nand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 90ff447bf043..e7786913280a 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -458,6 +458,7 @@ config MTD_NAND_MXC
>
> config MTD_NAND_SH_FLCTL
> tristate "Support for NAND on Renesas SuperH FLCTL"
> + depends on HAS_DMA
> depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> help
> Several Renesas SuperH CPU has FLCTL. This option enables support
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA
2014-02-21 20:27 ` Laurent Pinchart
@ 2014-02-21 20:49 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2014-02-21 20:49 UTC (permalink / raw)
To: Laurent Pinchart, Geert Uytterhoeven
Cc: Geert Uytterhoeven, linux-mtd, David Woodhouse, linux-kernel,
Richard Weinberger
Hi Geert,
On Fri, Feb 21, 2014 at 09:27:27PM +0100, Laurent Pinchart wrote:
> On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote:
> > If NO_DMA=y:
> >
> > drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
> > sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
> > sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> > drivers/mtd/nand/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > index 90ff447bf043..e7786913280a 100644
> > --- a/drivers/mtd/nand/Kconfig
> > +++ b/drivers/mtd/nand/Kconfig
> > @@ -458,6 +458,7 @@ config MTD_NAND_MXC
> >
> > config MTD_NAND_SH_FLCTL
> > tristate "Support for NAND on Renesas SuperH FLCTL"
> > + depends on HAS_DMA
> > depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> > help
> > Several Renesas SuperH CPU has FLCTL. This option enables support
It looks like Richard beat you to this. I have a similar patch queued up
in l2-mtd.git:
commit 4c8a074b3abab5a5d77c9a19f2fa5fb9d50f9908
Author: Richard Weinberger <richard@nod.at>
Date: Fri Jan 31 13:39:07 2014 +0100
mtd: nand: flctl: Add dependency on HAS_IOMEM and HAS_DMA
Thanks,
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-21 20:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 19:54 [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA Geert Uytterhoeven
2014-02-21 20:27 ` Laurent Pinchart
2014-02-21 20:49 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox