From: John Hubbard <jhubbard@nvidia.com>
To: zhong jiang <zhongjiang@huawei.com>, <akpm@linux-foundation.org>,
<minchan@kernel.org>, <mhocko@kernel.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: do not export ioremap_page_range symbol for external module
Date: Sun, 22 Jan 2017 17:30:46 -0800 [thread overview]
Message-ID: <8088cdd7-7abb-94ed-3bea-44d819045573@nvidia.com> (raw)
In-Reply-To: <588558EB.2060505@huawei.com>
On 01/22/2017 05:14 PM, zhong jiang wrote:
> On 2017/1/22 20:58, zhongjiang wrote:
>> From: zhong jiang <zhongjiang@huawei.com>
>>
>> Recently, I find the ioremap_page_range had been abusing. The improper
>> address mapping is a issue. it will result in the crash. so, remove
>> the symbol. It can be replaced by the ioremap_cache or others symbol.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> lib/ioremap.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/lib/ioremap.c b/lib/ioremap.c
>> index 86c8911..a3e14ce 100644
>> --- a/lib/ioremap.c
>> +++ b/lib/ioremap.c
>> @@ -144,4 +144,3 @@ int ioremap_page_range(unsigned long addr,
>>
>> return err;
>> }
>> -EXPORT_SYMBOL_GPL(ioremap_page_range);
> self nack
>
heh. What changed your mind?
next prev parent reply other threads:[~2017-01-23 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 12:58 [PATCH] mm: do not export ioremap_page_range symbol for external module zhongjiang
2017-01-22 22:25 ` John Hubbard
2017-01-23 1:14 ` zhong jiang
2017-01-23 1:30 ` John Hubbard [this message]
2017-01-23 11:52 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8088cdd7-7abb-94ed-3bea-44d819045573@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox