The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Oleksandr Natalenko <oleksandr@natalenko.name>,
	Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] Multidevice f2fs mount after disk rearrangement
Date: Wed, 8 Jan 2020 16:52:35 +0800	[thread overview]
Message-ID: <815fbd14-0fbd-9c44-8d86-4ab13a12dc7f@huawei.com> (raw)
In-Reply-To: <ee2cb1d7a6c1b51e1c8277a8feaafe6d@natalenko.name>

On 2020/1/7 2:40, Oleksandr Natalenko via Linux-f2fs-devel wrote:
> Hi.
> 
> On 06.01.2020 19:34, Jaegeuk Kim wrote:
>> Thank you for investigating this ahead of me. :) Yes, the device list 
>> is stored
>> in superblock, so hacking it manually should work.
>>
>> Let me think about a tool to tune that.
> 
> Thank you both for the replies.
> 
> IIUC, tune.f2fs is not there yet. I saw a submission, but I do not see 
> it as accepted, right?
> 
> Having this in tune.f2fs would be fine (assuming the assertion is 
> replaced with some meaningful hint message), but wouldn't it be more 
> convenient for an ordinary user to have implemented something like:
> 
> # mount -t f2fs /dev/sdb -o nextdev=/dev/sdc /mnt/fs

Hmm... sounds reasonable, however, the risk is obvious, if we mount with wrong
primary device, filesystem can be aware that with metadata sanity check, if we
mount with wrong secondary/... devices by mistake (or intentionally, people
may think filesystem should be aware illegal parameters....), filesystem won't
be aware of that, then metadata/data will be inconsistent...

Although that may also happen when we use tunesb.f2fs, but fsck.f2fs can be
followed to verify the modification of tunesb.f2fs, that would be much safer.

So I suggest we can do that in tools first, maybe implement nextdev mount option
if we have added metadata in secondary/... device.

Thanks,

> 
> Hm?
> 

  reply	other threads:[~2020-01-08  8:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-04 16:29 Multidevice f2fs mount after disk rearrangement Oleksandr Natalenko
2020-01-04 21:52 ` Oleksandr Natalenko
2020-01-06  3:41   ` [f2fs-dev] " Chao Yu
2020-01-06 18:40     ` Jaegeuk Kim
2020-01-08  8:37       ` Chao Yu
2020-01-06 18:34   ` Jaegeuk Kim
2020-01-06 18:40     ` Oleksandr Natalenko
2020-01-08  8:52       ` Chao Yu [this message]
2020-01-08 12:00         ` [f2fs-dev] " Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=815fbd14-0fbd-9c44-8d86-4ab13a12dc7f@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox