The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: "Ricardo B. Marlière" <rbm@suse.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"Jiri Olsa" <jolsa@kernel.org>,
	"Emil Tsalapatis" <emil@etsalapatis.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Alexis Lothoré (eBPF Foundation)" <alexis.lothore@bootlin.com>,
	"Christian Brauner" <brauner@kernel.org>
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] selftests/bpf: A few edge case fixes
Date: Thu, 16 Jul 2026 14:07:50 -0700	[thread overview]
Message-ID: <820ebdfa-b409-47d4-bff6-1b82dbdafbc5@linux.dev> (raw)
In-Reply-To: <20260710-selftests-bpf_fixes-v1-0-aa24dfd6f4f9@suse.com>

On 7/10/26 3:09 PM, Ricardo B. Marlière wrote:
> Hi,
> 
> Please consider merging the following fixes, found by means of targeting
> BPF selftests through openQA [1].
> 
> [1]: e.g. https://openqa.opensuse.org/tests/6087703
> 
> 1/4 ("libbpf: Search /lib64 and /lib in resolve_full_path()")
> - Hit by testing an older SLES root filesystem.
> 
> 2/4 ("selftests/bpf: Fix lsm_bdev dev_t encoding mismatch")
> - https://openqa.opensuse.org/tests/6087703/logfile?filename=test_progs.tap.txt#line-2706
> 
> 3/4 ("selftests/bpf: Install resolve_btfids.test.o.BTF where the test expects it")
> - https://openqa.opensuse.org/tests/6087703/logfile?filename=test_progs.tap.txt#line-3332
> 
> 4/4 ("selftests/bpf: Install bpftool where test_progs expects to find it")
> - https://openqa.opensuse.org/tests/6087703/logfile?filename=test_progs.tap.txt#line-806
> - https://openqa.opensuse.org/tests/6087703#step/test_bpftool_build_sh/1
> - https://openqa.opensuse.org/tests/6087703#step/test_doc_build_sh/1
> 
> The build process is done at runtime with BPF_STRICT_BUILD=0:
> https://openqa.opensuse.org/tests/6087703/logfile?filename=serial_terminal.txt#line-1937
> 
> Assisted-by: Claude Sonnet 5
> Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
> ---
> Ricardo B. Marlière (4):
>       selftests/bpf: Install bpftool where test_progs expects to find it
>       selftests/bpf: Install resolve_btfids.test.o.BTF where the test expects it
>       selftests/bpf: Fix lsm_bdev dev_t encoding mismatch
>       libbpf: Search /lib64 and /lib in resolve_full_path()
> 
>  tools/lib/bpf/libbpf.c                            | 3 ++-
>  tools/testing/selftests/bpf/Makefile              | 5 ++++-
>  tools/testing/selftests/bpf/prog_tests/lsm_bdev.c | 3 ++-
>  3 files changed, 8 insertions(+), 3 deletions(-)

Hi Ricardo,

Thank you for the patches, it's a good set of fixes.  We don't use
make install on CI, so it's not tested regularly.

I have a couple of comments, sending in a bit.


> ---
> base-commit: a635d6748234582ea287c5ffeae28b9b23f91c7e
> change-id: 20260710-selftests-bpf_fixes-06e9a2eb3c67
> 
> Best regards,
> --  
> Ricardo B. Marlière <rbm@suse.com>
> 


      parent reply	other threads:[~2026-07-16 21:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 22:09 [PATCH 0/4] selftests/bpf: A few edge case fixes Ricardo B. Marlière
2026-07-10 22:09 ` [PATCH 1/4] selftests/bpf: Install bpftool where test_progs expects to find it Ricardo B. Marlière
2026-07-13 15:32   ` Alexis Lothoré
2026-07-15 21:40     ` Ricardo B. Marlière
2026-07-16 21:09     ` Ihor Solodrai
2026-07-10 22:09 ` [PATCH 2/4] selftests/bpf: Install resolve_btfids.test.o.BTF where the test expects it Ricardo B. Marlière
2026-07-16 21:10   ` Ihor Solodrai
2026-07-10 22:09 ` [PATCH 3/4] selftests/bpf: Fix lsm_bdev dev_t encoding mismatch Ricardo B. Marlière
2026-07-16 21:11   ` Ihor Solodrai
2026-07-10 22:09 ` [PATCH 4/4] libbpf: Search /lib64 and /lib in resolve_full_path() Ricardo B. Marlière
2026-07-10 22:58   ` bot+bpf-ci
2026-07-16 21:12   ` Ihor Solodrai
2026-07-16 21:07 ` Ihor Solodrai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=820ebdfa-b409-47d4-bff6-1b82dbdafbc5@linux.dev \
    --to=ihor.solodrai@linux.dev \
    --cc=alexis.lothore@bootlin.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=rbm@suse.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox