[PATCH v2 1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA

[PATCH v2 1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA

[Vaishnav Achath]

J722S CSI BCDMA is similar to J721S2 CSI BCDMA and
supports both RX and TX channels. Add an entry for
J722S CSIRX BCDMA.

Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---

V1->V2:
  * Address review from Conor to add new J722S compatible
  * J722S BCDMA is more similar to J721S2 in terms of RX/TX support,
  add an entry alongside J721S2 instead of modifying AM62A.

V1: https://lore.kernel.org/all/20241125083914.2934815-1-vaishnav.a@ti.com/

 Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
index 27b8e1636560..37832c71bd8e 100644
--- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
+++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
@@ -196,7 +196,9 @@ allOf:
       properties:
         compatible:
           contains:
-            const: ti,j721s2-dmss-bcdma-csi
+            enum:
+              - ti,j721s2-dmss-bcdma-csi
+              - ti,j722s-dmss-bcdma-csi
     then:
       properties:
         ti,sci-rm-range-bchan: false
-- 
2.34.1

[PATCH v2 2/2] dmaengine: ti: k3-udma: Add support for J722S CSI BCDMA

[Vaishnav Achath]

J722S CSI BCDMA is similar to J721S2 CSI BCDMA but there are
slight integration differences like different PSIL thread
base ID which is handled in the driver. Add an entry
to support J722S CSIRX.

J722S TRM (11.2 Data Movement Subsystem):
https://www.ti.com/lit/zip/sprujb3

Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---

V1->V2:
	* Add new compatible for J722S instead of modifying AM62A

V1: https://lore.kernel.org/all/20241125083914.2934815-2-vaishnav.a@ti.com/

CSI2RX capture test results on J722S EVM with 4 x IMX219:
https://gist.github.com/vaishnavachath/e2eaed62ee8f53428ee9b830aaa02cc3

 drivers/dma/ti/k3-udma.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index b3f27b3f9209..7ed1956b4642 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -4404,6 +4404,18 @@ static struct udma_match_data j721s2_bcdma_csi_data = {
 	.soc_data = &j721s2_bcdma_csi_soc_data,
 };
 
+static struct udma_match_data j722s_bcdma_csi_data = {
+	.type = DMA_TYPE_BCDMA,
+	.psil_base = 0x3100,
+	.enable_memcpy_support = false,
+	.burst_size = {
+		TI_SCI_RM_UDMAP_CHAN_BURST_SIZE_64_BYTES, /* Normal Channels */
+		0, /* No H Channels */
+		0, /* No UH Channels */
+	},
+	.soc_data = &j721s2_bcdma_csi_soc_data,
+};
+
 static const struct of_device_id udma_of_match[] = {
 	{
 		.compatible = "ti,am654-navss-main-udmap",
@@ -4435,6 +4447,10 @@ static const struct of_device_id udma_of_match[] = {
 		.compatible = "ti,j721s2-dmss-bcdma-csi",
 		.data = &j721s2_bcdma_csi_data,
 	},
+	{
+		.compatible = "ti,j722s-dmss-bcdma-csi",
+		.data = &j722s_bcdma_csi_data,
+	},
 	{ /* Sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, udma_of_match);
-- 
2.34.1

Re: [PATCH v2 1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA

[Krzysztof Kozlowski]

On 26/11/2024 13:51, Vaishnav Achath wrote:
> J722S CSI BCDMA is similar to J721S2 CSI BCDMA and
> supports both RX and TX channels. Add an entry for
> J722S CSIRX BCDMA.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
> 
> V1->V2:
>   * Address review from Conor to add new J722S compatible
>   * J722S BCDMA is more similar to J721S2 in terms of RX/TX support,
>   add an entry alongside J721S2 instead of modifying AM62A.
> 
> V1: https://lore.kernel.org/all/20241125083914.2934815-1-vaishnav.a@ti.com/
> 
>  Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> index 27b8e1636560..37832c71bd8e 100644
> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> @@ -196,7 +196,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: ti,j721s2-dmss-bcdma-csi
> +            enum:
> +              - ti,j721s2-dmss-bcdma-csi
> +              - ti,j722s-dmss-bcdma-csi

This compatible was never documented. There is no dependency here, no
cover letter explaining where is this compatible introduced.




Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA

[Vaishnav Achath]

Hi Krzysztof,

On 26/11/24 19:49, Krzysztof Kozlowski wrote:
> On 26/11/2024 13:51, Vaishnav Achath wrote:
>> J722S CSI BCDMA is similar to J721S2 CSI BCDMA and
>> supports both RX and TX channels. Add an entry for
>> J722S CSIRX BCDMA.
> 
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 

I will fix this in next revision.

>>
>> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
>> ---
>>
>> V1->V2:
>>    * Address review from Conor to add new J722S compatible
>>    * J722S BCDMA is more similar to J721S2 in terms of RX/TX support,
>>    add an entry alongside J721S2 instead of modifying AM62A.
>>
>> V1: https://lore.kernel.org/all/20241125083914.2934815-1-vaishnav.a@ti.com/
>>
>>   Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
>> index 27b8e1636560..37832c71bd8e 100644
>> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
>> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
>> @@ -196,7 +196,9 @@ allOf:
>>         properties:
>>           compatible:
>>             contains:
>> -            const: ti,j721s2-dmss-bcdma-csi
>> +            enum:
>> +              - ti,j721s2-dmss-bcdma-csi
>> +              - ti,j722s-dmss-bcdma-csi
> 
> This compatible was never documented. There is no dependency here, no
> cover letter explaining where is this compatible introduced.
> 
> 

This was a mistake from my end, sorry about that, it was supposed to be 
introduced in this patch itself, will fix it in the next revision. Thank 
you for the review.

Thanks and Regards,
Vaishnav

> 
> 
> Best regards,
> Krzysztof