From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v11 07/10] erofs: introduce the page cache share feature
Date: Wed, 24 Dec 2025 18:05:11 +0800 [thread overview]
Message-ID: <84328aa9-5b84-4433-83ce-7147c100f5d2@linux.alibaba.com> (raw)
In-Reply-To: <5aad8772-458d-4040-a8b6-feff924c1d30@huawei.com>
On 2025/12/24 17:26, Hongbo Li wrote:
>
> Hi, Xiang
> On 2025/12/24 16:09, Gao Xiang wrote:
>>
...
>>
>> why return `struct erofs_inode_fingerprint` instead of:
>>
>> int erofs_xattr_get_ishare_fp(struct erofs_inode_fingerprint *fp,
>> struct inode *inode, const char *domain_id)
>>
>> instead?
>>
>
> How about declaring this as void erofs_xattr_fill_ishare_fp(struct erofs_inode_fingerprint *fp, struct inode *inode, const char *domain_id)? Because the return value seems useless.
I still perfer to return different values for this helper
even the final user doesn't use this.
Thanks,
Gao Xiang
>
> Thanks,
> Hongbo
next prev parent reply other threads:[~2025-12-24 10:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 4:09 [PATCH v11 00/10] erofs: Introduce page cache sharing feature Hongbo Li
2025-12-24 4:09 ` [PATCH v11 01/10] iomap: stash iomap read ctx in the private field of iomap_iter Hongbo Li
2025-12-24 4:09 ` [PATCH v11 02/10] erofs: hold read context in iomap_iter if needed Hongbo Li
2025-12-24 4:09 ` [PATCH v11 03/10] fs: Export alloc_empty_backing_file Hongbo Li
2025-12-24 4:09 ` [PATCH v11 04/10] erofs: move `struct erofs_anon_fs_type` to super.c Hongbo Li
2025-12-24 4:25 ` Gao Xiang
2025-12-24 6:26 ` Hongbo Li
2025-12-24 4:09 ` [PATCH v11 05/10] erofs: support user-defined fingerprint name Hongbo Li
2025-12-24 7:34 ` Gao Xiang
2025-12-25 3:17 ` kernel test robot
2025-12-25 4:08 ` kernel test robot
2025-12-25 6:24 ` Hongbo Li
2025-12-24 4:09 ` [PATCH v11 06/10] erofs: support domain-specific page cache share Hongbo Li
2025-12-24 7:35 ` Gao Xiang
2025-12-24 4:09 ` [PATCH v11 07/10] erofs: introduce the page cache share feature Hongbo Li
2025-12-24 8:09 ` Gao Xiang
2025-12-24 9:26 ` Hongbo Li
2025-12-24 10:05 ` Gao Xiang [this message]
2025-12-24 4:09 ` [PATCH v11 08/10] erofs: support unencoded inodes for page cache share Hongbo Li
2025-12-24 8:15 ` Gao Xiang
2025-12-24 4:09 ` [PATCH v11 09/10] erofs: support compressed " Hongbo Li
2025-12-24 8:18 ` Gao Xiang
2025-12-24 4:09 ` [PATCH v11 10/10] erofs: implement .fadvise " Hongbo Li
2025-12-24 8:19 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84328aa9-5b84-4433-83ce-7147c100f5d2@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=lihongbo22@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox