From: "Christian König" <christian.koenig@amd.com>
To: Rob Clark <robdclark@gmail.com>
Cc: Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rob Clark <robdclark@chromium.org>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
David Airlie <airlied@linux.ie>,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
Jonathan Marek <jonathan@marek.ca>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vladimir Lypak <vladimir.lypak@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend
Date: Thu, 17 Mar 2022 17:04:48 +0100 [thread overview]
Message-ID: <865abcff-9f52-dca4-df38-b11189c739ff@amd.com> (raw)
In-Reply-To: <CAF6AEGv36V8bLoDn5O1SW3iTUtzd3O1XeuT5gJxyLMxd1E-o3Q@mail.gmail.com>
Am 17.03.22 um 16:10 schrieb Rob Clark:
> [SNIP]
> userspace frozen != kthread frozen .. that is what this patch is
> trying to address, so we aren't racing between shutting down the hw
> and the scheduler shoveling more jobs at us.
Well exactly that's the problem. The scheduler is supposed to shoveling
more jobs at us until it is empty.
Thinking more about it we will then keep some dma_fence instance
unsignaled and that is and extremely bad idea since it can lead to
deadlocks during suspend.
So this patch here is an absolute clear NAK from my side. If amdgpu is
doing something similar that is a severe bug and needs to be addressed
somehow.
Regards,
Christian.
>
> BR,
> -R
>
next prev parent reply other threads:[~2022-03-17 16:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 23:46 [PATCH 0/3] drm/msm/gpu: More system suspend fixes Rob Clark
2022-03-10 23:46 ` [PATCH 1/3] drm/msm/gpu: Rename runtime suspend/resume functions Rob Clark
2022-03-11 9:26 ` AngeloGioacchino Del Regno
2022-03-10 23:46 ` [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend Rob Clark
2022-03-17 9:59 ` Daniel Vetter
2022-03-17 10:06 ` Christian König
2022-03-17 14:58 ` Matthew Brost
2022-03-17 15:10 ` Rob Clark
2022-03-17 16:04 ` Christian König [this message]
2022-03-17 16:18 ` Rob Clark
2022-03-17 16:44 ` Christian König
2022-03-17 17:29 ` Daniel Vetter
2022-03-17 17:35 ` Rob Clark
2022-03-17 18:10 ` Andrey Grodzovsky
2022-03-17 18:25 ` Rob Clark
2022-03-17 19:49 ` Andrey Grodzovsky
2022-03-17 20:35 ` Rob Clark
2022-03-18 16:04 ` Andrey Grodzovsky
2022-03-18 16:20 ` Rob Clark
2022-03-18 16:27 ` Andrey Grodzovsky
2022-03-18 17:22 ` Rob Clark
2022-03-18 20:14 ` Andrey Grodzovsky
2022-03-17 17:46 ` Andrey Grodzovsky
2022-03-10 23:46 ` [PATCH 3/3] drm/msm/gpu: Remove mutex from wait_event condition Rob Clark
2022-03-17 20:45 ` [Freedreno] " Akhil P Oommen
2022-03-17 21:07 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865abcff-9f52-dca4-df38-b11189c739ff@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=andrey.grodzovsky@amd.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bjorn.andersson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vladimir.lypak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox