From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>,
"Ingo Molnar" <mingo@elte.hu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Jeff Garzik" <jeff@garzik.org>,
"Ayaz Abdulla" <aabdulla@nvidia.com>,
"Thomas Gleixner" <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: regression caused by: genirq: do not leave interupts enabled on free_irq
Date: Thu, 10 Apr 2008 23:13:59 -0700 [thread overview]
Message-ID: <86802c440804102313k4546cd73s7bffb30a14239472@mail.gmail.com> (raw)
last week found:
after latest kernel kexec RHEL 5.1 or other stack kernel, the nvidia
forcedeth doesn't work anymore.
I stared at forcedeth.c two days. and revert every patches about that
doesn't help.
and figure out 2.6.25-rc2 works.
with git-bisect found
commit 89d694b9dbe769ca1004e01db0ca43964806a611
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Mon Feb 18 18:25:17 2008 +0100
genirq: do not leave interupts enabled on free_irq
The default_disable() function was changed in commit:
76d2160147f43f982dfe881404cfde9fd0a9da21
genirq: do not mask interrupts by default
It removed the mask function in favour of the default delayed
interrupt disabling. Unfortunately this also broke the shutdown in
free_irq() when the last handler is removed from the interrupt for
those architectures which rely on the default implementations. Now we
can end up with a enabled interrupt line after the last handler was
removed, which can result in spurious interrupts.
Fix this by adding a default_shutdown function, which is only
installed, when the irqchip implementation does provide neither a
shutdown nor a disable function.
[@stable: affected versions: .21 - .24 ]
Pointed-out-by: Michael Hennerich <Michael.Hennerich@analog.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Cc: stable@kernel.org
Tested-by: Michael Hennerich <Michael.Hennerich@analog.com>
caused the regression.
it affected all my servers that are using Nvidia MCP55.
maybe we need to revert that patch.
YH
next reply other threads:[~2008-04-11 6:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 6:13 Yinghai Lu [this message]
2008-04-11 7:01 ` regression caused by: genirq: do not leave interupts enabled on free_irq Thomas Gleixner
2008-04-11 7:14 ` Yinghai Lu
2008-04-11 7:17 ` Yinghai Lu
2008-04-11 7:30 ` Eric W. Biederman
2008-04-11 8:40 ` Yinghai Lu
2008-04-11 15:59 ` Daniel Barkalow
2008-04-11 10:31 ` Thomas Gleixner
2008-04-11 15:19 ` Rafael J. Wysocki
2008-04-11 16:23 ` Yinghai Lu
2008-04-11 18:22 ` Yinghai Lu
2008-04-11 19:48 ` Yinghai Lu
2008-04-15 7:44 ` Andrew Morton
2008-04-15 8:03 ` Yinghai Lu
2008-04-15 8:17 ` Ingo Molnar
2008-04-15 8:23 ` Yinghai Lu
2008-04-15 8:06 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440804102313k4546cd73s7bffb30a14239472@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox