From: "Bjørn Mork" <bjorn@mork.no>
To: Yongxin Liu <yongxin.liu@windriver.com>
Cc: <andy@infradead.org>, <dvhart@infradead.org>,
<platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mario.limonciello@dell.com>
Subject: Re: [PATCH] Revert "platform/x86: wmi: Destroy on cleanup rather than unregister"
Date: Fri, 22 Nov 2019 13:09:56 +0100 [thread overview]
Message-ID: <8736eg5cyz.fsf@miraculix.mork.no> (raw)
In-Reply-To: <87blt45eew.fsf@miraculix.mork.no> ("Bjørn Mork"'s message of "Fri, 22 Nov 2019 12:38:47 +0100")
Bjørn Mork <bjorn@mork.no> writes:
> Maybe we should add a WARN_ON(!MAJOR(devt)) or similar to
> device_destroy() to prevent similar future problems?
No, that's definitely not a good idea. We have examples like
drivers/tty/vt/vt.c which (ab)use the devt with zero major and a
unique minor to keep track of devices. So forget about any warning.
But the device_destroy's with a static MKDEV(0,0) should be removed.
Bjørn
next prev parent reply other threads:[~2019-11-22 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 5:27 [PATCH] Revert "platform/x86: wmi: Destroy on cleanup rather than unregister" Yongxin Liu
2019-11-22 1:39 ` Liu, Yongxin
2019-11-22 11:38 ` Bjørn Mork
2019-11-22 12:09 ` Bjørn Mork [this message]
2020-10-27 14:36 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736eg5cyz.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yongxin.liu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox