* [PATCH] ASoC: SDCA: Add missing sdca_fdl_free_state definition
@ 2026-08-10 9:55 Luis Henriques
2026-08-10 10:43 ` Maciej Strozek
0 siblings, 1 reply; 3+ messages in thread
From: Luis Henriques @ 2026-08-10 9:55 UTC (permalink / raw)
To: Charles Keepax, Maciej Strozek, Bard Liao, Pierre-Louis Bossart,
Jaroslav Kysela, Takashi Iwai, Mark Brown
Cc: linux-sound, patches, linux-kernel, kernel-dev, Luis Henriques
This patch fixes a build failure introduced by commit 0880082c27b6 ("ASoC:
SDCA: Remove devm from primary IRQ cleanup"). It simply adds function
sdca_fdl_free_state when SND_SOC_SDCA_FDL isn't defined.
Here's the build error:
../sound/soc/sdca/sdca_interrupts.c:471:56: error: 'sdca_fdl_free_state' undeclared (first use in this function); did you mean 'sdca_jack_free_state'?
Fixes: 0880082c27b6 ("ASoC: SDCA: Remove devm from primary IRQ cleanup")
Signed-off-by: Luis Henriques <luis@igalia.com>
---
include/sound/sdca_fdl.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/sound/sdca_fdl.h b/include/sound/sdca_fdl.h
index dc33927b82bd..bc3600cdd2ec 100644
--- a/include/sound/sdca_fdl.h
+++ b/include/sound/sdca_fdl.h
@@ -83,6 +83,10 @@ static inline int sdca_fdl_alloc_state(struct sdca_interrupt *interrupt)
return 0;
}
+static inline void sdca_fdl_free_state(struct sdca_interrupt *interrupt)
+{
+}
+
static inline int sdca_fdl_process(struct sdca_interrupt *interrupt)
{
return 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: SDCA: Add missing sdca_fdl_free_state definition
2026-08-10 9:55 [PATCH] ASoC: SDCA: Add missing sdca_fdl_free_state definition Luis Henriques
@ 2026-08-10 10:43 ` Maciej Strozek
2026-08-10 11:16 ` Luis Henriques
0 siblings, 1 reply; 3+ messages in thread
From: Maciej Strozek @ 2026-08-10 10:43 UTC (permalink / raw)
To: Luis Henriques, Charles Keepax, Bard Liao, Pierre-Louis Bossart,
Jaroslav Kysela, Takashi Iwai, Mark Brown
Cc: linux-sound, patches, linux-kernel, kernel-dev
W dniu pon, 10.08.2026 o godzinie 10∶55 +0100, użytkownik Luis
Henriques napisał:
> This patch fixes a build failure introduced by commit 0880082c27b6
> ("ASoC:
> SDCA: Remove devm from primary IRQ cleanup"). It simply adds
> function
> sdca_fdl_free_state when SND_SOC_SDCA_FDL isn't defined.
>
This was already fixed here:
https://lore.kernel.org/linux-sound/20260730130602.3747053-1-ckeepax@opensource.cirrus.com/T/#u
--
Regards,
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: SDCA: Add missing sdca_fdl_free_state definition
2026-08-10 10:43 ` Maciej Strozek
@ 2026-08-10 11:16 ` Luis Henriques
0 siblings, 0 replies; 3+ messages in thread
From: Luis Henriques @ 2026-08-10 11:16 UTC (permalink / raw)
To: Maciej Strozek
Cc: Charles Keepax, Bard Liao, Pierre-Louis Bossart, Jaroslav Kysela,
Takashi Iwai, Mark Brown, linux-sound, patches, linux-kernel,
kernel-dev
On Mon, Aug 10 2026, Maciej Strozek wrote:
> W dniu pon, 10.08.2026 o godzinie 10∶55 +0100, użytkownik Luis
> Henriques napisał:
>> This patch fixes a build failure introduced by commit 0880082c27b6
>> ("ASoC:
>> SDCA: Remove devm from primary IRQ cleanup"). It simply adds
>> function
>> sdca_fdl_free_state when SND_SOC_SDCA_FDL isn't defined.
>>
> This was already fixed here:
> https://lore.kernel.org/linux-sound/20260730130602.3747053-1-ckeepax@opensource.cirrus.com/T/#u
I did a quick search before sending a fix and totally failed to see that.
Sorry for the noise!
Cheers,
--
Luís
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-10 11:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-10 9:55 [PATCH] ASoC: SDCA: Add missing sdca_fdl_free_state definition Luis Henriques
2026-08-10 10:43 ` Maciej Strozek
2026-08-10 11:16 ` Luis Henriques
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox