* [PATCH] Documentation: Fix typo in 'taskstats-struct.rst'
@ 2024-11-28 6:38 Saru2003
2024-12-06 16:46 ` Jonathan Corbet
0 siblings, 1 reply; 4+ messages in thread
From: Saru2003 @ 2024-11-28 6:38 UTC (permalink / raw)
To: bsingharora, corbet; +Cc: linux-doc, linux-kernel, Saru2003
Corrected a typo in the 'taskstats-struct.rst' documentation. The macro name 'TAKSTATS_VERSION' was mistakenly mentioned instead of the correct 'TASKSTATS_VERSION'. The corrected line now accurately references the macro 'TASKSTATS_VERSION', which is defined in '<linux/taskstats.h>'.
Signed-off-by: Sarveshwaar SS <sarvesh20123@gmail.com>
Signed-off-by: Saru2003 <sarvesh20123@gmail.com>
---
Documentation/accounting/taskstats-struct.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/accounting/taskstats-struct.rst b/Documentation/accounting/taskstats-struct.rst
index ca90fd489c9a..acca51c34157 100644
--- a/Documentation/accounting/taskstats-struct.rst
+++ b/Documentation/accounting/taskstats-struct.rst
@@ -47,7 +47,7 @@ should not change the relative position of each field within the struct.
1) Common and basic accounting fields::
/* The version number of this struct. This field is always set to
- * TAKSTATS_VERSION, which is defined in <linux/taskstats.h>.
+ * TASKSTATS_VERSION, which is defined in <linux/taskstats.h>.
* Each time the struct is changed, the value should be incremented.
*/
__u16 version;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: Fix typo in 'taskstats-struct.rst'
2024-11-28 6:38 [PATCH] Documentation: Fix typo in 'taskstats-struct.rst' Saru2003
@ 2024-12-06 16:46 ` Jonathan Corbet
2024-12-08 8:33 ` [PATCH] Documentation/accounting: Fix typo in taskstats-struct.rst Saru2003
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Corbet @ 2024-12-06 16:46 UTC (permalink / raw)
To: Saru2003, bsingharora; +Cc: linux-doc, linux-kernel, Saru2003
Saru2003 <sarvesh20123@gmail.com> writes:
Thanks for working to improve our documentation. There are a couple of
problems here, though:
> Corrected a typo in the 'taskstats-struct.rst' documentation. The macro name 'TAKSTATS_VERSION' was mistakenly mentioned instead of the correct 'TASKSTATS_VERSION'. The corrected line now accurately references the macro 'TASKSTATS_VERSION', which is defined in '<linux/taskstats.h>'.
Please wrap your changelog lines to a reasonable length. This changelog
is also a bit more verbose than it really needs to be, but that's less
important.
> Signed-off-by: Sarveshwaar SS <sarvesh20123@gmail.com>
> Signed-off-by: Saru2003 <sarvesh20123@gmail.com>
You should only sign off the patch once, and the signoff should include
your actual name, please.
> Documentation/accounting/taskstats-struct.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/accounting/taskstats-struct.rst b/Documentation/accounting/taskstats-struct.rst
> index ca90fd489c9a..acca51c34157 100644
> --- a/Documentation/accounting/taskstats-struct.rst
> +++ b/Documentation/accounting/taskstats-struct.rst
> @@ -47,7 +47,7 @@ should not change the relative position of each field within the struct.
> 1) Common and basic accounting fields::
>
> /* The version number of this struct. This field is always set to
> - * TAKSTATS_VERSION, which is defined in <linux/taskstats.h>.
> + * TASKSTATS_VERSION, which is defined in <linux/taskstats.h>.
> * Each time the struct is changed, the value should be incremented.
The change itself is fine.
Thanks,
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Documentation/accounting: Fix typo in taskstats-struct.rst
2024-12-06 16:46 ` Jonathan Corbet
@ 2024-12-08 8:33 ` Saru2003
2024-12-13 15:45 ` Jonathan Corbet
0 siblings, 1 reply; 4+ messages in thread
From: Saru2003 @ 2024-12-08 8:33 UTC (permalink / raw)
To: bsingharora, corbet; +Cc: linux-doc, linux-kernel, Saru2003
Corrected a typo in the 'taskstats-struct.rst' documentation. The macro
name 'TAKSTATS_VERSION' was mistakenly mentioned instead of the correct
'TASKSTATS_VERSION'. The corrected line now references the proper macro
'TASKSTATS_VERSION', defined in '<linux/taskstats.h>'.
Signed-off-by: Sarveshwaar SS <sarvesh20123@gmail.com>
---
Documentation/accounting/taskstats-struct.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/accounting/taskstats-struct.rst b/Documentation/accounting/taskstats-struct.rst
index ca90fd489c9a..acca51c34157 100644
--- a/Documentation/accounting/taskstats-struct.rst
+++ b/Documentation/accounting/taskstats-struct.rst
@@ -47,7 +47,7 @@ should not change the relative position of each field within the struct.
1) Common and basic accounting fields::
/* The version number of this struct. This field is always set to
- * TAKSTATS_VERSION, which is defined in <linux/taskstats.h>.
+ * TASKSTATS_VERSION, which is defined in <linux/taskstats.h>.
* Each time the struct is changed, the value should be incremented.
*/
__u16 version;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation/accounting: Fix typo in taskstats-struct.rst
2024-12-08 8:33 ` [PATCH] Documentation/accounting: Fix typo in taskstats-struct.rst Saru2003
@ 2024-12-13 15:45 ` Jonathan Corbet
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2024-12-13 15:45 UTC (permalink / raw)
To: Saru2003, bsingharora; +Cc: linux-doc, linux-kernel, Saru2003
Saru2003 <sarvesh20123@gmail.com> writes:
> Corrected a typo in the 'taskstats-struct.rst' documentation. The macro
> name 'TAKSTATS_VERSION' was mistakenly mentioned instead of the correct
> 'TASKSTATS_VERSION'. The corrected line now references the proper macro
> 'TASKSTATS_VERSION', defined in '<linux/taskstats.h>'.
>
> Signed-off-by: Sarveshwaar SS <sarvesh20123@gmail.com>
> ---
> Documentation/accounting/taskstats-struct.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/accounting/taskstats-struct.rst b/Documentation/accounting/taskstats-struct.rst
> index ca90fd489c9a..acca51c34157 100644
> --- a/Documentation/accounting/taskstats-struct.rst
> +++ b/Documentation/accounting/taskstats-struct.rst
> @@ -47,7 +47,7 @@ should not change the relative position of each field within the struct.
> 1) Common and basic accounting fields::
>
> /* The version number of this struct. This field is always set to
> - * TAKSTATS_VERSION, which is defined in <linux/taskstats.h>.
> + * TASKSTATS_VERSION, which is defined in <linux/taskstats.h>.
> * Each time the struct is changed, the value should be incremented.
For future reference: when you send an updated version of the patch,
please mark it as such ("v2" for example) and put a description of what
has changed after the "---" line.
I've applied this one, thanks.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-13 15:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-28 6:38 [PATCH] Documentation: Fix typo in 'taskstats-struct.rst' Saru2003
2024-12-06 16:46 ` Jonathan Corbet
2024-12-08 8:33 ` [PATCH] Documentation/accounting: Fix typo in taskstats-struct.rst Saru2003
2024-12-13 15:45 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox