* [PATCH] brcm80211: BRCM_TRACING should depend on TRACING
@ 2024-09-24 12:09 Geert Uytterhoeven
2024-09-24 12:51 ` Arend Van Spriel
2024-10-17 14:23 ` wifi: " Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2024-09-24 12:09 UTC (permalink / raw)
To: Arend van Spriel, Kalle Valo, John W . Linville, Seth Forshee,
Pieter-Paul Giesberts
Cc: linux-wireless, brcm80211, brcm80211-dev-list.pdl,
linux-trace-kernel, linux-kernel, Geert Uytterhoeven
When tracing is disabled, there is no point in asking the user about
enabling Broadcom wireless device tracing.
Fixes: f5c4f10852d42012 ("brcm80211: Allow trace support to be enabled separately from debug")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/wireless/broadcom/brcm80211/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/Kconfig b/drivers/net/wireless/broadcom/brcm80211/Kconfig
index 3a1a35b5672f1a27..19d0c003f6262675 100644
--- a/drivers/net/wireless/broadcom/brcm80211/Kconfig
+++ b/drivers/net/wireless/broadcom/brcm80211/Kconfig
@@ -27,6 +27,7 @@ source "drivers/net/wireless/broadcom/brcm80211/brcmfmac/Kconfig"
config BRCM_TRACING
bool "Broadcom device tracing"
depends on BRCMSMAC || BRCMFMAC
+ depends on TRACING
help
If you say Y here, the Broadcom wireless drivers will register
with ftrace to dump event information into the trace ringbuffer.
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] brcm80211: BRCM_TRACING should depend on TRACING
2024-09-24 12:09 [PATCH] brcm80211: BRCM_TRACING should depend on TRACING Geert Uytterhoeven
@ 2024-09-24 12:51 ` Arend Van Spriel
2024-09-24 13:35 ` Kalle Valo
2024-10-17 14:23 ` wifi: " Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Arend Van Spriel @ 2024-09-24 12:51 UTC (permalink / raw)
To: Geert Uytterhoeven, Kalle Valo, John W . Linville, Seth Forshee,
Pieter-Paul Giesberts
Cc: linux-wireless, brcm80211, brcm80211-dev-list.pdl,
linux-trace-kernel, linux-kernel
On September 24, 2024 2:09:35 PM Geert Uytterhoeven <geert@linux-m68k.org>
wrote:
> When tracing is disabled, there is no point in asking the user about
> enabling Broadcom wireless device tracing.
>
> Fixes: f5c4f10852d42012 ("brcm80211: Allow trace support to be enabled
> separately from debug")
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/net/wireless/broadcom/brcm80211/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] brcm80211: BRCM_TRACING should depend on TRACING
2024-09-24 12:51 ` Arend Van Spriel
@ 2024-09-24 13:35 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2024-09-24 13:35 UTC (permalink / raw)
To: Arend Van Spriel
Cc: Geert Uytterhoeven, John W . Linville, Seth Forshee,
Pieter-Paul Giesberts, linux-wireless, brcm80211,
brcm80211-dev-list.pdl, linux-trace-kernel, linux-kernel
Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
> On September 24, 2024 2:09:35 PM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
>> When tracing is disabled, there is no point in asking the user about
>> enabling Broadcom wireless device tracing.
>>
>> Fixes: f5c4f10852d42012 ("brcm80211: Allow trace support to be
>> enabled separately from debug")
>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
I'm planning to take this to wireless and I'll add 'wifi:' to the title.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: wifi: brcm80211: BRCM_TRACING should depend on TRACING
2024-09-24 12:09 [PATCH] brcm80211: BRCM_TRACING should depend on TRACING Geert Uytterhoeven
2024-09-24 12:51 ` Arend Van Spriel
@ 2024-10-17 14:23 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2024-10-17 14:23 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Arend van Spriel, John W . Linville, Seth Forshee,
Pieter-Paul Giesberts, linux-wireless, brcm80211,
brcm80211-dev-list.pdl, linux-trace-kernel, linux-kernel,
Geert Uytterhoeven
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> When tracing is disabled, there is no point in asking the user about
> enabling Broadcom wireless device tracing.
>
> Fixes: f5c4f10852d42012 ("brcm80211: Allow trace support to be enabled separately from debug")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless.git, thanks.
b73b2069528f wifi: brcm80211: BRCM_TRACING should depend on TRACING
--
https://patchwork.kernel.org/project/linux-wireless/patch/81a29b15eaacc1ac1fb421bdace9ac0c3385f40f.1727179742.git.geert@linux-m68k.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-17 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 12:09 [PATCH] brcm80211: BRCM_TRACING should depend on TRACING Geert Uytterhoeven
2024-09-24 12:51 ` Arend Van Spriel
2024-09-24 13:35 ` Kalle Valo
2024-10-17 14:23 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox