public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Chen Yu <yu.c.chen@intel.com>, Abel Wu <wuyun.abel@bytedance.com>
Cc: linux-kernel@vger.kernel.org, Tim Chen <tim.c.chen@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mel Gorman <mgorman@suse.de>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Barry Song <21cnbao@gmail.com>,
	Barry Song <song.bao.hua@hisilicon.com>,
	Yicong Yang <yangyicong@hisilicon.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Len Brown <len.brown@intel.com>, Ben Segall <bsegall@google.com>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Aubrey Li <aubrey.li@intel.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [PATCH v2][RFC] sched/fair: Change SIS_PROP to search idle CPU based on sum of util_avg
Date: Mon, 14 Mar 2022 10:34:30 -0700	[thread overview]
Message-ID: <87541edf7b46c1475f73cf464a9edca932f65da5.camel@linux.intel.com> (raw)
In-Reply-To: <20220314125657.GA30418@chenyu5-mobl1>

On Mon, 2022-03-14 at 20:56 +0800, Chen Yu wrote:
> 
> > 
> > So nr_scan will probably be updated at llc-domain-lb-interval, which
> > is llc_size milliseconds. Since load can be varied a lot during such
> > a period, would this brought accuracy issues?
> > 
> I agree there might be delay in reflecting the latest utilization.
> The sum_util calculated by periodic load balance after 112ms would be
> decay to about 0.5 * 0.5 * 0.5 * 0.7 = 8.75%.
> But consider that this is a server platform, I have an impression that
> the CPU utilization jitter during a small period of time is not a regular
> scenario? It seems to be a trade-off. Checking the util_avg in newidle
> load balance path would be more frequent, but it also brings overhead -
> multiple CPUs write/read the per-LLC shared variable and introduces cache
> false sharing. But to make this more robust, maybe we can add time interval
> control in newidle load balance too.
> 
> 

Also the idea is we allow ourselves to be non-optimal in terms of
scheduling for the short term variations.  But we want to make sure that if
there's a long term trend in the load behavior, the scheduler should
adjust for that.  I think if you see high utilization and CPUs are
all close to fully busy for quite a while, that is a long term trend 
that overwhelms any short load jitters.

Tim


  reply	other threads:[~2022-03-14 17:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10  0:52 [PATCH v2][RFC] sched/fair: Change SIS_PROP to search idle CPU based on sum of util_avg Chen Yu
2022-03-14  4:53 ` Abel Wu
2022-03-14 12:56   ` Chen Yu
2022-03-14 17:34     ` Tim Chen [this message]
2022-03-16 16:13       ` Chen Yu
2022-03-15 11:37 ` K Prateek Nayak
2022-03-16 11:54   ` Chen Yu
2022-03-17 10:39     ` K Prateek Nayak
2022-04-02 14:35       ` K Prateek Nayak
2022-04-09 15:15         ` Chen Yu
2022-03-17 17:39 ` Yicong Yang
2022-03-18  3:43   ` Chen Yu
2022-04-02 10:11     ` Yicong Yang
2022-04-09 15:09       ` Chen Yu
2022-04-11  8:04         ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87541edf7b46c1475f73cf464a9edca932f65da5.camel@linux.intel.com \
    --to=tim.c.chen@linux.intel.com \
    --cc=21cnbao@gmail.com \
    --cc=aubrey.li@intel.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=song.bao.hua@hisilicon.com \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=tim.c.chen@intel.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=wuyun.abel@bytedance.com \
    --cc=yangyicong@hisilicon.com \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox