public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clocksource: delete unnecessary comments
@ 2025-09-10  1:47 Enlin Mu
  2025-09-10 15:18 ` Thomas Gleixner
  0 siblings, 1 reply; 2+ messages in thread
From: Enlin Mu @ 2025-09-10  1:47 UTC (permalink / raw)
  To: jstultz, tglx, sboyd, linux-kernel, enlinmu, enlin.mu, enlin.mu

From: Enlin Mu <enlin.mu@unisoc.com>

The new format is as follows:
  clocksource: jiffies mask:0xfff max_cycles:0xffff,max_idle_ns: 7645000 ns

Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
---
 kernel/time/clocksource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 0aef0e349e49..c70880376ec6 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -1218,7 +1218,7 @@ void __clocksource_update_freq_scale(struct clocksource *cs, u32 scale, u32 freq
 
 	clocksource_update_max_deferment(cs);
 
-	pr_info("%s: mask: 0x%llx max_cycles: 0x%llx, max_idle_ns: %lld ns\n",
+	pr_info("%s mask: 0x%llx max_cycles: 0x%llx, max_idle_ns: %lld ns\n",
 		cs->name, cs->mask, cs->max_cycles, cs->max_idle_ns);
 }
 EXPORT_SYMBOL_GPL(__clocksource_update_freq_scale);
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clocksource: delete unnecessary comments
  2025-09-10  1:47 [PATCH] clocksource: delete unnecessary comments Enlin Mu
@ 2025-09-10 15:18 ` Thomas Gleixner
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2025-09-10 15:18 UTC (permalink / raw)
  To: Enlin Mu, jstultz, sboyd, linux-kernel, enlinmu, enlin.mu,
	enlin.mu

On Wed, Sep 10 2025 at 09:47, Enlin Mu wrote:
> From: Enlin Mu <enlin.mu@unisoc.com>
>
> The new format is as follows:
>   clocksource: jiffies mask:0xfff max_cycles:0xffff,max_idle_ns: 7645000 ns

What's the point of this exercise?

We are not changing stuff just because, there has to be a reason and a
justification for changes. See Documentation/process/ for further
information.

Also I don't see where this change deletes a comment in the code, which
is what the subject line claims to do.

Thanks,

        tglx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-10 15:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10  1:47 [PATCH] clocksource: delete unnecessary comments Enlin Mu
2025-09-10 15:18 ` Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox