public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Elitebook, 645 G9
@ 2023-02-05 18:56 Elvis Angelaccio
  2023-02-06  7:43 ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Elvis Angelaccio @ 2023-02-05 18:56 UTC (permalink / raw)
  To: tiwai; +Cc: alsa-devel, linux-kernel

The HP Elitebook 645 G9 laptop (with motherboard model 89D2) uses the
ALC236 codec and requires the alc236_fixup_hp_mute_led_micmute_vref
fixup in order to enable mute/micmute LEDs.

Note: the alc236_fixup_hp_gpio_led fixup, which is used by the Elitebook
640 G9, does not work with the 645 G9.

Signed-off-by: Elvis Angelaccio <elvis.angelaccio@kde.org>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4055a8f5880a..11bc71b152ff 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9427,6 +9427,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8aab, "HP EliteBook 650 G9 (MB 8AA9)", ALC236_FIXUP_HP_GPIO_LED),
 	 SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
-- 
2.39.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Elitebook, 645 G9
  2023-02-05 18:56 [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Elitebook, 645 G9 Elvis Angelaccio
@ 2023-02-06  7:43 ` Takashi Iwai
  2023-02-06 19:00   ` Elvis Angelaccio
  0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2023-02-06  7:43 UTC (permalink / raw)
  To: Elvis Angelaccio; +Cc: tiwai, alsa-devel, linux-kernel

On Sun, 05 Feb 2023 19:56:18 +0100,
Elvis Angelaccio wrote:
> 
> The HP Elitebook 645 G9 laptop (with motherboard model 89D2) uses the
> ALC236 codec and requires the alc236_fixup_hp_mute_led_micmute_vref
> fixup in order to enable mute/micmute LEDs.
> 
> Note: the alc236_fixup_hp_gpio_led fixup, which is used by the Elitebook
> 640 G9, does not work with the 645 G9.
> 
> Signed-off-by: Elvis Angelaccio <elvis.angelaccio@kde.org>

Thanks, applied.

But the table is sorted in SSID, so I rearranged the entry at
applying.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Elitebook, 645 G9
  2023-02-06  7:43 ` Takashi Iwai
@ 2023-02-06 19:00   ` Elvis Angelaccio
  0 siblings, 0 replies; 3+ messages in thread
From: Elvis Angelaccio @ 2023-02-06 19:00 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: tiwai, alsa-devel, linux-kernel

Thanks!

Cheers,
Elvis

On 06/02/23 08:43, Takashi Iwai wrote:
> On Sun, 05 Feb 2023 19:56:18 +0100,
> Elvis Angelaccio wrote:
>>
>> The HP Elitebook 645 G9 laptop (with motherboard model 89D2) uses the
>> ALC236 codec and requires the alc236_fixup_hp_mute_led_micmute_vref
>> fixup in order to enable mute/micmute LEDs.
>>
>> Note: the alc236_fixup_hp_gpio_led fixup, which is used by the Elitebook
>> 640 G9, does not work with the 645 G9.
>>
>> Signed-off-by: Elvis Angelaccio <elvis.angelaccio@kde.org>
> 
> Thanks, applied.
> 
> But the table is sorted in SSID, so I rearranged the entry at
> applying.
> 
> 
> Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-06 19:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-05 18:56 [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Elitebook, 645 G9 Elvis Angelaccio
2023-02-06  7:43 ` Takashi Iwai
2023-02-06 19:00   ` Elvis Angelaccio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox