* [PATCH] ath10k: fix erroneous return value
@ 2016-02-10 16:58 Anton Protopopov
2016-02-11 23:24 ` Julian Calaby
2016-03-04 8:41 ` Valo, Kalle
0 siblings, 2 replies; 3+ messages in thread
From: Anton Protopopov @ 2016-02-10 16:58 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless, netdev, linux-kernel, Anton Protopopov
The ath10k_pci_hif_exchange_bmi_msg() function may return the positive
value EIO instead of -EIO in case of error.
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index ee925c6..526acde 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1756,7 +1756,7 @@ static int ath10k_pci_hif_exchange_bmi_msg(struct ath10k *ar,
DMA_FROM_DEVICE);
ret = dma_mapping_error(ar->dev, resp_paddr);
if (ret) {
- ret = EIO;
+ ret = -EIO;
goto err_req;
}
--
2.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ath10k: fix erroneous return value
2016-02-10 16:58 [PATCH] ath10k: fix erroneous return value Anton Protopopov
@ 2016-02-11 23:24 ` Julian Calaby
2016-03-04 8:41 ` Valo, Kalle
1 sibling, 0 replies; 3+ messages in thread
From: Julian Calaby @ 2016-02-11 23:24 UTC (permalink / raw)
To: Anton Protopopov
Cc: Kalle Valo, ath10k, linux-wireless, netdev,
linux-kernel@vger.kernel.org
Hi All,
On Thu, Feb 11, 2016 at 3:58 AM, Anton Protopopov
<a.s.protopopov@gmail.com> wrote:
> The ath10k_pci_hif_exchange_bmi_msg() function may return the positive
> value EIO instead of -EIO in case of error.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
This looks right to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/net/wireless/ath/ath10k/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
> index ee925c6..526acde 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -1756,7 +1756,7 @@ static int ath10k_pci_hif_exchange_bmi_msg(struct ath10k *ar,
> DMA_FROM_DEVICE);
> ret = dma_mapping_error(ar->dev, resp_paddr);
> if (ret) {
> - ret = EIO;
> + ret = -EIO;
> goto err_req;
> }
>
> --
> 2.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ath10k: fix erroneous return value
2016-02-10 16:58 [PATCH] ath10k: fix erroneous return value Anton Protopopov
2016-02-11 23:24 ` Julian Calaby
@ 2016-03-04 8:41 ` Valo, Kalle
1 sibling, 0 replies; 3+ messages in thread
From: Valo, Kalle @ 2016-03-04 8:41 UTC (permalink / raw)
To: Anton Protopopov
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org
Anton Protopopov <a.s.protopopov@gmail.com> writes:
> The ath10k_pci_hif_exchange_bmi_msg() function may return the positive
> value EIO instead of -EIO in case of error.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Applied, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-04 8:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 16:58 [PATCH] ath10k: fix erroneous return value Anton Protopopov
2016-02-11 23:24 ` Julian Calaby
2016-03-04 8:41 ` Valo, Kalle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox