[PATCH] i915: slow acpi_lid_open() causes flickering - V2

[PATCH] i915: slow acpi_lid_open() causes flickering - V2

[Thomas Meyer]

acpi_lid_open() could take up to 10ms on my computer.  Some component is
calling the drm GETCONNECTOR ioctl many times in a row.  This results in
flickering (for example, when starting a video).  Fix it by assuming an
always connected lid status.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
 drivers/gpu/drm/i915/intel_lvds.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index aa74e59..05a31ae 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -623,6 +623,13 @@ static const struct dmi_system_id bad_lid_status[] = {
 		},
 	},
 	{
+		.ident = "Aspire 1810T",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1810T"),
+		},
+	},
+	{
 		.ident = "PC-81005",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "MALATA"),
@@ -643,7 +650,7 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
 {
 	enum drm_connector_status status = connector_status_connected;
 
-	if (!acpi_lid_open() && !dmi_check_system(bad_lid_status))
+	if (!dmi_check_system(bad_lid_status) && !acpi_lid_open())
 		status = connector_status_disconnected;
 
 	return status;
-- 
1.6.6

Re: [PATCH] i915: slow acpi_lid_open() causes flickering - V2

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

On Tue, 02 Feb 2010 20:09:04 +0100, Thomas Meyer <thomas@m3y3r.de> wrote:
> acpi_lid_open() could take up to 10ms on my computer.  Some component is
> calling the drm GETCONNECTOR ioctl many times in a row.  This results in
> flickering (for example, when starting a video).  Fix it by assuming an
> always connected lid status.

Applied.  Thanks!

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]