From: Nam Cao <namcao@linutronix.de>
To: Charlie Jenkins <thecharlesjenkins@gmail.com>,
Xiaofeng Yuan <xiaofengmian@163.com>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] riscv: probes: simulate c.jal instruction
Date: Sat, 27 Jun 2026 12:59:50 +0200 [thread overview]
Message-ID: <878q805jvd.fsf@yellow.woof> (raw)
In-Reply-To: <178253409654.105999.9483335947060007692.b4-review@b4>
Charlie Jenkins <thecharlesjenkins@gmail.com> writes:
> I was looking at this recently trying to figure out why this hadn't been
> implemented and couldn't determine why this one was special, it might be
> because it is 32-bit only.
Yes. When I looked into this, I had no idea how to test rv32, so I skipped it.
> Since it is 32-bit only, can you put ifdefs
> around it for riscv32 (#if __riscv_xlen == 32) ?
Except for slightly bigger kernel size, it does not hurt to keep. And
#if stuff is quite ugly. But I'm fine with it either way.
> Can you also add a test case to:
> arch/riscv/kernel/tests/kprobes/test-kprobes-asm.S?
I already have a patch adding test case. Let me send it.
Nam
next prev parent reply other threads:[~2026-06-27 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 0:19 [PATCH v4] riscv: probes: simulate c.jal instruction Xiaofeng Yuan
2026-06-27 4:21 ` Charlie Jenkins
2026-06-27 10:59 ` Nam Cao [this message]
2026-06-27 11:52 ` Nam Cao
2026-06-27 11:04 ` Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878q805jvd.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=thecharlesjenkins@gmail.com \
--cc=xiaofengmian@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox