From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH 4/4] gpio: pxa: add pin control gpio direction and request
Date: Thu, 10 Dec 2015 18:33:10 +0100 [thread overview]
Message-ID: <878u52jjjd.fsf@belgarion.home> (raw)
In-Reply-To: <1448746665-13422-5-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sat, 28 Nov 2015 22:37:45 +0100")
Robert Jarzmik <robert.jarzmik@free.fr> writes:
> +static int pxa_gpio_request(struct gpio_chip *chip, unsigned int offset)
> +{
> + return pinctrl_request_gpio(chip->base + offset);
> +}
> +
> +static void pxa_gpio_free(struct gpio_chip *chip, unsigned int offset)
> +{
> + pinctrl_free_gpio(chip->base + offset);
> +}
This part will need a bit of rework : in the case of a platform data board,
pinctrl_*() returns -EPROBE_DEFER, preventing any gpio user to claim a gpio.
Either I hold with this patch to see how pxa pinctrl goes, or drop it, but in
any case this one is not ready yet for merge.
Cheers.
--
Robert
next prev parent reply other threads:[~2015-12-10 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 21:37 [PATCH 0/4] gpio: pxa: integrate with pincontrol Robert Jarzmik
2015-11-28 21:37 ` [PATCH 1/4] gpio: pxa: convert to one gpiochip Robert Jarzmik
2015-12-10 15:04 ` Linus Walleij
2015-12-10 17:28 ` Robert Jarzmik
2015-11-28 21:37 ` [PATCH 2/4] gpio: pxa: convert to devm_ioremap Robert Jarzmik
2015-12-10 15:05 ` Linus Walleij
2015-11-28 21:37 ` [PATCH 3/4] gpio: pxa: change the interrupt management Robert Jarzmik
2015-11-28 23:23 ` kbuild test robot
2015-11-29 10:03 ` Robert Jarzmik
2015-12-10 15:06 ` Linus Walleij
2015-11-28 21:37 ` [PATCH 4/4] gpio: pxa: add pin control gpio direction and request Robert Jarzmik
2015-12-10 17:33 ` Robert Jarzmik [this message]
2015-12-09 22:58 ` [PATCH 0/4] gpio: pxa: integrate with pincontrol Linus Walleij
2015-12-10 7:28 ` Robert Jarzmik
2015-12-10 15:02 ` Linus Walleij
2015-12-10 17:31 ` Robert Jarzmik
2015-12-14 13:42 ` Linus Walleij
2015-12-14 21:10 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u52jjjd.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=gnurou@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox