* [PATCH] ALSA: hda/realtek: Add subwoofer quirk for Infinix ZERO BOOK 13
@ 2024-10-27 22:16 Piyush Raj Chouhan
2024-10-28 15:02 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Piyush Raj Chouhan @ 2024-10-27 22:16 UTC (permalink / raw)
To: linux-sound; +Cc: tiwai, linux-kernel, alsa-devel, pc1598
From: pc1598 <piyushchouhan1598@gmail.com>
Infinix ZERO BOOK 13 has a 2+2 speaker system which isn't probed correctly.
This patch adds a quirk with the proper pin connections.
Also The mic in this laptop suffers too high gain resulting in mostly fan noise being recorded,
This patch Also limit mic boost.
HW Probe for device; https://linux-hardware.org/?probe=a2e892c47b
Test: All 4 speaker works, Mic has low noise.
Signed-off-by: Piyush Raj Chouhan <piyushchouhan1598@gmail.com>
---
sound/pci/hda/patch_realtek.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3567b14b52b7..075935707f8a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7551,6 +7551,7 @@ enum {
ALC290_FIXUP_SUBWOOFER_HSJACK,
ALC269_FIXUP_THINKPAD_ACPI,
ALC269_FIXUP_DMIC_THINKPAD_ACPI,
+ ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13,
ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO,
ALC255_FIXUP_ACER_MIC_NO_PRESENCE,
ALC255_FIXUP_ASUS_MIC_NO_PRESENCE,
@@ -7996,6 +7997,16 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc269_fixup_pincfg_U7x7_headset_mic,
},
+ [ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x14, 0x90170151 }, /* use as internal speaker (LFE) */
+ { 0x1b, 0x90170152 }, /* use as internal speaker (back) */
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC269_FIXUP_LIMIT_INT_MIC_BOOST
+ },
[ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
@@ -10989,6 +11000,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1d72, 0x1945, "Redmi G", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1d72, 0x1947, "RedmiBook Air", ALC255_FIXUP_XIAOMI_HEADSET_MIC),
SND_PCI_QUIRK(0x2782, 0x0214, "VAIO VJFE-CL", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x2782, 0x0228, "Infinix ZERO BOOK 13", ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13),
SND_PCI_QUIRK(0x2782, 0x0232, "CHUWI CoreBook XPro", ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO),
SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME),
SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC),
--
2.46.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add subwoofer quirk for Infinix ZERO BOOK 13
2024-10-27 22:16 [PATCH] ALSA: hda/realtek: Add subwoofer quirk for Infinix ZERO BOOK 13 Piyush Raj Chouhan
@ 2024-10-28 15:02 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2024-10-28 15:02 UTC (permalink / raw)
To: Piyush Raj Chouhan; +Cc: linux-sound, linux-kernel, alsa-devel
On Sun, 27 Oct 2024 23:16:55 +0100,
Piyush Raj Chouhan wrote:
>
> From: pc1598 <piyushchouhan1598@gmail.com>
Please drop this line, otherwise it's taken as the author.
We prefer having the same address as specified in Signed-off-by tag.
thanks,
Takashi
> Infinix ZERO BOOK 13 has a 2+2 speaker system which isn't probed correctly.
> This patch adds a quirk with the proper pin connections.
> Also The mic in this laptop suffers too high gain resulting in mostly fan noise being recorded,
> This patch Also limit mic boost.
>
> HW Probe for device; https://linux-hardware.org/?probe=a2e892c47b
>
> Test: All 4 speaker works, Mic has low noise.
> Signed-off-by: Piyush Raj Chouhan <piyushchouhan1598@gmail.com>
> ---
> sound/pci/hda/patch_realtek.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3567b14b52b7..075935707f8a 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7551,6 +7551,7 @@ enum {
> ALC290_FIXUP_SUBWOOFER_HSJACK,
> ALC269_FIXUP_THINKPAD_ACPI,
> ALC269_FIXUP_DMIC_THINKPAD_ACPI,
> + ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13,
> ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO,
> ALC255_FIXUP_ACER_MIC_NO_PRESENCE,
> ALC255_FIXUP_ASUS_MIC_NO_PRESENCE,
> @@ -7996,6 +7997,16 @@ static const struct hda_fixup alc269_fixups[] = {
> .type = HDA_FIXUP_FUNC,
> .v.func = alc269_fixup_pincfg_U7x7_headset_mic,
> },
> + [ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13] = {
> + .type = HDA_FIXUP_PINS,
> + .v.pins = (const struct hda_pintbl[]) {
> + { 0x14, 0x90170151 }, /* use as internal speaker (LFE) */
> + { 0x1b, 0x90170152 }, /* use as internal speaker (back) */
> + { }
> + },
> + .chained = true,
> + .chain_id = ALC269_FIXUP_LIMIT_INT_MIC_BOOST
> + },
> [ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO] = {
> .type = HDA_FIXUP_PINS,
> .v.pins = (const struct hda_pintbl[]) {
> @@ -10989,6 +11000,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1d72, 0x1945, "Redmi G", ALC256_FIXUP_ASUS_HEADSET_MIC),
> SND_PCI_QUIRK(0x1d72, 0x1947, "RedmiBook Air", ALC255_FIXUP_XIAOMI_HEADSET_MIC),
> SND_PCI_QUIRK(0x2782, 0x0214, "VAIO VJFE-CL", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> + SND_PCI_QUIRK(0x2782, 0x0228, "Infinix ZERO BOOK 13", ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13),
> SND_PCI_QUIRK(0x2782, 0x0232, "CHUWI CoreBook XPro", ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO),
> SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME),
> SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC),
> --
> 2.46.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ALSA: hda/realtek: Add subwoofer quirk for Infinix ZERO BOOK 13
@ 2024-10-28 15:55 Piyush Raj Chouhan
2024-10-29 9:03 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Piyush Raj Chouhan @ 2024-10-28 15:55 UTC (permalink / raw)
To: =inux-sound, linux-sound
Cc: tiwai, linux-kernel, alsa-devel, Piyush Raj Chouhan
Infinix ZERO BOOK 13 has a 2+2 speaker system which isn't probed correctly.
This patch adds a quirk with the proper pin connections.
Also The mic in this laptop suffers too high gain resulting in mostly fan noise being recorded,
This patch Also limit mic boost.
HW Probe for device; https://linux-hardware.org/?probe=a2e892c47b
Test: All 4 speaker works, Mic has low noise.
Signed-off-by: Piyush Raj Chouhan <piyushchouhan1598@gmail.com>
---
sound/pci/hda/patch_realtek.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3567b14b52b7..075935707f8a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7551,6 +7551,7 @@ enum {
ALC290_FIXUP_SUBWOOFER_HSJACK,
ALC269_FIXUP_THINKPAD_ACPI,
ALC269_FIXUP_DMIC_THINKPAD_ACPI,
+ ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13,
ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO,
ALC255_FIXUP_ACER_MIC_NO_PRESENCE,
ALC255_FIXUP_ASUS_MIC_NO_PRESENCE,
@@ -7996,6 +7997,16 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc269_fixup_pincfg_U7x7_headset_mic,
},
+ [ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x14, 0x90170151 }, /* use as internal speaker (LFE) */
+ { 0x1b, 0x90170152 }, /* use as internal speaker (back) */
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC269_FIXUP_LIMIT_INT_MIC_BOOST
+ },
[ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
@@ -10989,6 +11000,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1d72, 0x1945, "Redmi G", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1d72, 0x1947, "RedmiBook Air", ALC255_FIXUP_XIAOMI_HEADSET_MIC),
SND_PCI_QUIRK(0x2782, 0x0214, "VAIO VJFE-CL", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x2782, 0x0228, "Infinix ZERO BOOK 13", ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13),
SND_PCI_QUIRK(0x2782, 0x0232, "CHUWI CoreBook XPro", ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO),
SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME),
SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC),
--
2.46.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add subwoofer quirk for Infinix ZERO BOOK 13
2024-10-28 15:55 Piyush Raj Chouhan
@ 2024-10-29 9:03 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2024-10-29 9:03 UTC (permalink / raw)
To: Piyush Raj Chouhan; +Cc: =inux-sound, linux-sound, linux-kernel, alsa-devel
On Mon, 28 Oct 2024 16:55:16 +0100,
Piyush Raj Chouhan wrote:
>
> Infinix ZERO BOOK 13 has a 2+2 speaker system which isn't probed correctly.
> This patch adds a quirk with the proper pin connections.
> Also The mic in this laptop suffers too high gain resulting in mostly fan noise being recorded,
> This patch Also limit mic boost.
>
> HW Probe for device; https://linux-hardware.org/?probe=a2e892c47b
>
> Test: All 4 speaker works, Mic has low noise.
> Signed-off-by: Piyush Raj Chouhan <piyushchouhan1598@gmail.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-29 9:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-27 22:16 [PATCH] ALSA: hda/realtek: Add subwoofer quirk for Infinix ZERO BOOK 13 Piyush Raj Chouhan
2024-10-28 15:02 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2024-10-28 15:55 Piyush Raj Chouhan
2024-10-29 9:03 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox