add DSD for ThinkBook 16p G4 IRH with Subsystem Id of :

add DSD for ThinkBook 16p G4 IRH with Subsystem Id of :

[Huayu Zhang]

Sorry for missing the info within patch and not familiar with the
mailing system using git. As mentioned in the subject,
the patch is using to fix the sound issue of ThinkBook 16p G4 IRH with
Subsystem Id of : 0x17aa38a9. But this just enable the downside (bass)
speakers. When I tried to adjust the volumn, it atually mapped to the
frequency division (the lower volumn actually set the bass speakers,
and higher volumn map to the louder sound of up facing speakers).
Wondering if this related to ALSA?

Re: add DSD for ThinkBook 16p G4 IRH with Subsystem Id of :

[Takashi Iwai]

On Mon, 08 Jan 2024 13:51:36 +0100,
Huayu Zhang wrote:
> 
> Sorry for missing the info within patch and not familiar with the
> mailing system using git. As mentioned in the subject,
> the patch is using to fix the sound issue of ThinkBook 16p G4 IRH with
> Subsystem Id of : 0x17aa38a9. But this just enable the downside (bass)
> speakers. When I tried to adjust the volumn, it atually mapped to the
> frequency division (the lower volumn actually set the bass speakers,
> and higher volumn map to the louder sound of up facing speakers).
> Wondering if this related to ALSA?

The amp behavior is a question to Cirrus people, I suppose.

In anyway, the patch can't be taken as is.  You need to submit the
patch in a more formal way.

- Correct the subject line with a proper prefix, e.g.
    [PATCH] ALSA: hda: Add DSD for ....
  When resubmitting with some changes, put the revision number, too,
    [PATCH v2] ALSA: hda: Add DSD for ....

- Give the proper patch description in the patch itself.

- Put your Signed-off-by line after the patch description.
  It's a legal requirement.

Please refer to Documentation/process/submitting-patches.rst for
details.


thanks,

Takashi