public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Cc: kys@exchange.microsoft.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
	leann.ogasawara@canonical.com, alexng@microsoft.com
Subject: Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions
Date: Thu, 25 Aug 2016 14:13:10 +0200	[thread overview]
Message-ID: <87d1kxavxl.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <xuny8tvlwise.fsf@redhat.com> (Yauheni Kaliuta's message of "Thu, 25 Aug 2016 07:53:53 +0300")

Yauheni Kaliuta <yauheni.kaliuta@redhat.com> writes:

> Hi, kys!
>
>>>>>> On Wed, 24 Aug 2016 16:23:10 -0700, kys   wrote:
>
> [...]
>
>  > -static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
>  > +static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
>  >  {
>  >  	struct list_head *cur;
>  >  	struct hv_hotadd_state *has;
>  > +	struct hv_hotadd_gap *gap;
>  >  	unsigned long residual, new_inc;
>
>  >  	if (list_empty(&dm_device.ha_region_list))
>
> One "return false;" left here.
>

This is removed in patch 4/5 of this series and false is 0 anyway)

[...]

-- 
  Vitaly

  reply	other threads:[~2016-08-25 12:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 23:22 [PATCH 0/5] Drivers: hv: balloon: Miscellaneous fixes kys
2016-08-24 23:23 ` [PATCH 1/5] Drivers: hv: balloon: keep track of where ha_region starts kys
2016-08-24 23:23   ` [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions kys
2016-08-25  4:53     ` Yauheni Kaliuta
2016-08-25 12:13       ` Vitaly Kuznetsov [this message]
2016-08-25 17:00       ` KY Srinivasan
2016-08-24 23:23   ` [PATCH 3/5] Drivers: hv: balloon: don't wait for ol_waitevent when memhp_auto_online is enabled kys
2016-08-24 23:23   ` [PATCH 4/5] Drivers: hv: balloon: replace ha_region_mutex with spinlock kys
2016-08-24 23:23   ` [PATCH 5/5] Drivers: hv: balloon: Use available memory value in pressure report kys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1kxavxl.fsf@vitty.brq.redhat.com \
    --to=vkuznets@redhat.com \
    --cc=alexng@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=kys@exchange.microsoft.com \
    --cc=leann.ogasawara@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=yauheni.kaliuta@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox