[PATCH] irqchip: ath79: remove unused function

[PATCH] irqchip: ath79: remove unused function

[Rosen Penev]

It seems ath79_cpu_irq_init was used a long time ago before the OF code
was written for it. Remove to avoid a no previous prototype error for
this unused function.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/irqchip/irq-ath79-cpu.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/irqchip/irq-ath79-cpu.c b/drivers/irqchip/irq-ath79-cpu.c
index 923e4bba3776..9b7273a7f8ce 100644
--- a/drivers/irqchip/irq-ath79-cpu.c
+++ b/drivers/irqchip/irq-ath79-cpu.c
@@ -85,10 +85,3 @@ static int __init ar79_cpu_intc_of_init(
 }
 IRQCHIP_DECLARE(ar79_cpu_intc, "qca,ar7100-cpu-intc",
 		ar79_cpu_intc_of_init);
-
-void __init ath79_cpu_irq_init(unsigned irq_wb_chan2, unsigned irq_wb_chan3)
-{
-	irq_wb_chan[2] = irq_wb_chan2;
-	irq_wb_chan[3] = irq_wb_chan3;
-	mips_cpu_irq_init();
-}
-- 
2.54.0

Re: [PATCH] irqchip: ath79: remove unused function

[Thomas Gleixner]

On Tue, May 05 2026 at 00:50, Rosen Penev wrote:

Please use the proper subsystem prefix as documented:

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html

> It seems ath79_cpu_irq_init was used a long time ago before the OF code

It seems? Either it is or not.

Also please find and describe the commit which removed the usage and
failed to remove the function.

Thanks,

        tglx

Re: [PATCH] irqchip: ath79: remove unused function

[Rosen Penev]

On Tue, May 5, 2026 at 12:43 PM Thomas Gleixner <tglx@kernel.org> wrote:
>
> On Tue, May 05 2026 at 00:50, Rosen Penev wrote:
>
> Please use the proper subsystem prefix as documented:
>
>   https://www.kernel.org/doc/html/latest/process/maintainer-tip.html
>
> > It seems ath79_cpu_irq_init was used a long time ago before the OF code
>
> It seems? Either it is or not.
>
> Also please find and describe the commit which removed the usage and
> failed to remove the function.
Ah hah. Found where it stopped being used:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=51fa4f8912c0934cf1410f435516d2abbcf88a9e

Found from https://lore.kernel.org/all/202412011509.kGQkDr1y-lkp@intel.com/
which seems to have never been fixed.

Should I add a fixes tag?

A small note: this patch has been carried since the OF conversion of
this target downstream in OpenWrt but never upstreamed.
>
> Thanks,
>
>         tglx