The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable
@ 2026-05-11  8:04 Gautam Menghani
  2026-05-12 17:48 ` Harsh Prateek Bora
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Gautam Menghani @ 2026-05-11  8:04 UTC (permalink / raw)
  To: maddy, mpe, npiggin, chleroy; +Cc: Gautam Menghani, linuxppc-dev, linux-kernel

From: Gautam Menghani <gautam@linux.ibm.com>

The comments explaining the h_facility_unavailable interrupt have mentioned
the vector number as 0xf60 instead of 0xf80. Fix this typo.

Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
---
 arch/powerpc/kernel/exceptions-64s.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
index b7229430ca94..2696fbbca3b6 100644
--- a/arch/powerpc/kernel/exceptions-64s.S
+++ b/arch/powerpc/kernel/exceptions-64s.S
@@ -2498,7 +2498,7 @@ EXC_COMMON_BEGIN(facility_unavailable_common)
 
 
 /**
- * Interrupt 0xf60 - Hypervisor Facility Unavailable Interrupt.
+ * Interrupt 0xf80 - Hypervisor Facility Unavailable Interrupt.
  * This is a synchronous interrupt in response to
  * executing an instruction without access to the facility that can only
  * be resolved in HV mode (e.g., HFSCR).
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable
  2026-05-11  8:04 [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable Gautam Menghani
@ 2026-05-12 17:48 ` Harsh Prateek Bora
  2026-05-12 18:03 ` Amit Machhiwal
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Harsh Prateek Bora @ 2026-05-12 17:48 UTC (permalink / raw)
  To: Gautam Menghani, maddy, mpe, npiggin, chleroy
  Cc: Gautam Menghani, linuxppc-dev, linux-kernel



On 11/05/26 1:34 pm, Gautam Menghani wrote:
> From: Gautam Menghani <gautam@linux.ibm.com>
> 
> The comments explaining the h_facility_unavailable interrupt have mentioned
> the vector number as 0xf60 instead of 0xf80. Fix this typo.
> 
> Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
> ---
>   arch/powerpc/kernel/exceptions-64s.S | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index b7229430ca94..2696fbbca3b6 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -2498,7 +2498,7 @@ EXC_COMMON_BEGIN(facility_unavailable_common)
>   
>   
>   /**
> - * Interrupt 0xf60 - Hypervisor Facility Unavailable Interrupt.
> + * Interrupt 0xf80 - Hypervisor Facility Unavailable Interrupt.

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

>    * This is a synchronous interrupt in response to
>    * executing an instruction without access to the facility that can only
>    * be resolved in HV mode (e.g., HFSCR).


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable
  2026-05-11  8:04 [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable Gautam Menghani
  2026-05-12 17:48 ` Harsh Prateek Bora
@ 2026-05-12 18:03 ` Amit Machhiwal
  2026-05-13  4:00 ` Ritesh Harjani
  2026-05-13  9:05 ` Vaibhav Jain
  3 siblings, 0 replies; 5+ messages in thread
From: Amit Machhiwal @ 2026-05-12 18:03 UTC (permalink / raw)
  To: Gautam Menghani
  Cc: maddy, mpe, npiggin, chleroy, Gautam Menghani, linuxppc-dev,
	linux-kernel

On 2026/05/11 01:34 PM, Gautam Menghani wrote:
> From: Gautam Menghani <gautam@linux.ibm.com>
> 
> The comments explaining the h_facility_unavailable interrupt have mentioned
> the vector number as 0xf60 instead of 0xf80. Fix this typo.
> 
> Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
> ---
>  arch/powerpc/kernel/exceptions-64s.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>

> 
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index b7229430ca94..2696fbbca3b6 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -2498,7 +2498,7 @@ EXC_COMMON_BEGIN(facility_unavailable_common)
>  
>  
>  /**
> - * Interrupt 0xf60 - Hypervisor Facility Unavailable Interrupt.
> + * Interrupt 0xf80 - Hypervisor Facility Unavailable Interrupt.
>   * This is a synchronous interrupt in response to
>   * executing an instruction without access to the facility that can only
>   * be resolved in HV mode (e.g., HFSCR).
> -- 
> 2.53.0
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable
  2026-05-11  8:04 [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable Gautam Menghani
  2026-05-12 17:48 ` Harsh Prateek Bora
  2026-05-12 18:03 ` Amit Machhiwal
@ 2026-05-13  4:00 ` Ritesh Harjani
  2026-05-13  9:05 ` Vaibhav Jain
  3 siblings, 0 replies; 5+ messages in thread
From: Ritesh Harjani @ 2026-05-13  4:00 UTC (permalink / raw)
  To: Gautam Menghani, maddy, mpe, npiggin, chleroy
  Cc: Gautam Menghani, linuxppc-dev, linux-kernel

Gautam Menghani <Gautam.Menghani@ibm.com> writes:

> From: Gautam Menghani <gautam@linux.ibm.com>
>
> The comments explaining the h_facility_unavailable interrupt have mentioned
> the vector number as 0xf60 instead of 0xf80. Fix this typo.
>

Yup, looks like it got copied over from the above definition of Facility
Unavailable Interrupt. Nice catch!

LGTM. Please feel free to add:

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable
  2026-05-11  8:04 [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable Gautam Menghani
                   ` (2 preceding siblings ...)
  2026-05-13  4:00 ` Ritesh Harjani
@ 2026-05-13  9:05 ` Vaibhav Jain
  3 siblings, 0 replies; 5+ messages in thread
From: Vaibhav Jain @ 2026-05-13  9:05 UTC (permalink / raw)
  To: Gautam Menghani, maddy, mpe, npiggin, chleroy
  Cc: Gautam Menghani, linuxppc-dev, linux-kernel

Hey Gautam,

Thanks for the patch. Since this patch doesnt have any functional or
code change can you please put a 'trivial' suffix to it patch title like
[1] or some other suffix indicating its a non-functional change. That
way maintainers can easily pull the patch without worrying much about a
regression.

[1]
https://git.kernel.org/powerpc/c/d2827e5e2e0f0941a651f4b1ca5e9b778c4b5293

Gautam Menghani <Gautam.Menghani@ibm.com> writes:
> From: Gautam Menghani <gautam@linux.ibm.com>
>
> The comments explaining the h_facility_unavailable interrupt have mentioned
> the vector number as 0xf60 instead of 0xf80. Fix this typo.
>
> Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
> ---
>  arch/powerpc/kernel/exceptions-64s.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index b7229430ca94..2696fbbca3b6 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -2498,7 +2498,7 @@ EXC_COMMON_BEGIN(facility_unavailable_common)
>  
>  
>  /**
> - * Interrupt 0xf60 - Hypervisor Facility Unavailable Interrupt.
> + * Interrupt 0xf80 - Hypervisor Facility Unavailable Interrupt.
>   * This is a synchronous interrupt in response to
>   * executing an instruction without access to the facility that can only
>   * be resolved in HV mode (e.g., HFSCR).
> -- 
> 2.53.0
>
>

-- 
Cheers
~ Vaibhav

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-05-13  9:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-11  8:04 [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable Gautam Menghani
2026-05-12 17:48 ` Harsh Prateek Bora
2026-05-12 18:03 ` Amit Machhiwal
2026-05-13  4:00 ` Ritesh Harjani
2026-05-13  9:05 ` Vaibhav Jain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox