public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] ALSA: hda/realtek: Fix headset mic for TongFang  X6AR55xU
@ 2026-01-22 17:13 Werner Sembach
  2026-01-22 17:13 ` [PATCH 1/2] Revert "ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU" Werner Sembach
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Werner Sembach @ 2026-01-22 17:13 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: Werner Sembach, linux-sound, linux-kernel

Sorry the last patch I sent didn't actually work. Here is a revert and
a new version. Luckily it was catched quickly.

Tim Guttzeit (1):
  ALSA: hda/realtek: Really fix headset mic for TongFang  X6AR55xU

Werner Sembach (1):
  Revert "ALSA: hda/realtek: Fix headset mic for TongFang  X6AR55xU"

 sound/hda/codecs/realtek/alc269.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] Revert "ALSA: hda/realtek: Fix headset mic for TongFang  X6AR55xU"
  2026-01-22 17:13 [PATCH 0/2] ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU Werner Sembach
@ 2026-01-22 17:13 ` Werner Sembach
  2026-01-22 17:13 ` [PATCH 2/2] ALSA: hda/realtek: Really fix headset mic for TongFang X6AR55xU Werner Sembach
  2026-01-23 11:36 ` [PATCH 0/2] ALSA: hda/realtek: Fix " Takashi Iwai
  2 siblings, 0 replies; 5+ messages in thread
From: Werner Sembach @ 2026-01-22 17:13 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: Werner Sembach, linux-sound, linux-kernel

This reverts commit 89f135b774c71ab603a5da66d0c1449e76750389.

Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
 sound/hda/codecs/realtek/alc269.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 24d534f6d3d3a..eb6197d19078c 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7674,10 +7674,6 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 		{0x12, 0x90a60140},
 		{0x19, 0x04a11030},
 		{0x21, 0x04211020}),
-	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1d05, "TongFang", ALC274_FIXUP_HP_HEADSET_MIC,
-		{0x17, 0x90170110},
-		{0x19, 0x03a11030},
-		{0x21, 0x03211020}),
 	SND_HDA_PIN_QUIRK(0x10ec0282, 0x1025, "Acer", ALC282_FIXUP_ACER_DISABLE_LINEOUT,
 		ALC282_STANDARD_PINS,
 		{0x12, 0x90a609c0},
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ALSA: hda/realtek: Really fix headset mic for TongFang  X6AR55xU
  2026-01-22 17:13 [PATCH 0/2] ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU Werner Sembach
  2026-01-22 17:13 ` [PATCH 1/2] Revert "ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU" Werner Sembach
@ 2026-01-22 17:13 ` Werner Sembach
  2026-01-23 11:36 ` [PATCH 0/2] ALSA: hda/realtek: Fix " Takashi Iwai
  2 siblings, 0 replies; 5+ messages in thread
From: Werner Sembach @ 2026-01-22 17:13 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai
  Cc: Tim Guttzeit, Werner Sembach, linux-sound, linux-kernel

From: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>

Add a PCI quirk to enable microphone detection on the headphone jack of
TongFang X6AR55xU devices.

Signed-off-by: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index eb6197d19078c..c709d19a824d3 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7205,6 +7205,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1d05, 0x1409, "TongFang GMxIXxx", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1d05, 0x300f, "TongFang X6AR5xxY", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1d05, 0x3019, "TongFang X6FR5xxY", ALC2XX_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x1d05, 0x3031, "TongFang X6AR55xU", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1d17, 0x3288, "Haier Boyue G42", ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS),
 	SND_PCI_QUIRK(0x1d72, 0x1602, "RedmiBook", ALC255_FIXUP_XIAOMI_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1d72, 0x1701, "XiaomiNotebook Pro", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE),
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] ALSA: hda/realtek: Fix headset mic for TongFang  X6AR55xU
  2026-01-22 17:13 [PATCH 0/2] ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU Werner Sembach
  2026-01-22 17:13 ` [PATCH 1/2] Revert "ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU" Werner Sembach
  2026-01-22 17:13 ` [PATCH 2/2] ALSA: hda/realtek: Really fix headset mic for TongFang X6AR55xU Werner Sembach
@ 2026-01-23 11:36 ` Takashi Iwai
  2026-01-23 15:47   ` Werner Sembach
  2 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2026-01-23 11:36 UTC (permalink / raw)
  To: Werner Sembach; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel

On Thu, 22 Jan 2026 18:13:42 +0100,
Werner Sembach wrote:
> 
> Sorry the last patch I sent didn't actually work. Here is a revert and
> a new version. Luckily it was catched quickly.
> 
> Tim Guttzeit (1):
>   ALSA: hda/realtek: Really fix headset mic for TongFang  X6AR55xU
> 
> Werner Sembach (1):
>   Revert "ALSA: hda/realtek: Fix headset mic for TongFang  X6AR55xU"

Could you rather fold into a single patch with a Fixes tag?
Or, at least, give more details in the revert patch.  It says only
reverting, and it doesn't help understanding what's going on.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU
  2026-01-23 11:36 ` [PATCH 0/2] ALSA: hda/realtek: Fix " Takashi Iwai
@ 2026-01-23 15:47   ` Werner Sembach
  0 siblings, 0 replies; 5+ messages in thread
From: Werner Sembach @ 2026-01-23 15:47 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel


Am 23.01.26 um 12:36 schrieb Takashi Iwai:
> On Thu, 22 Jan 2026 18:13:42 +0100,
> Werner Sembach wrote:
>> Sorry the last patch I sent didn't actually work. Here is a revert and
>> a new version. Luckily it was catched quickly.
>>
>> Tim Guttzeit (1):
>>    ALSA: hda/realtek: Really fix headset mic for TongFang  X6AR55xU
>>
>> Werner Sembach (1):
>>    Revert "ALSA: hda/realtek: Fix headset mic for TongFang  X6AR55xU"
> Could you rather fold into a single patch with a Fixes tag?
ok will do
> Or, at least, give more details in the revert patch.  It says only
> reverting, and it doesn't help understanding what's going on.
>
>
> thanks,
>
> Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-01-23 15:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-22 17:13 [PATCH 0/2] ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU Werner Sembach
2026-01-22 17:13 ` [PATCH 1/2] Revert "ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU" Werner Sembach
2026-01-22 17:13 ` [PATCH 2/2] ALSA: hda/realtek: Really fix headset mic for TongFang X6AR55xU Werner Sembach
2026-01-23 11:36 ` [PATCH 0/2] ALSA: hda/realtek: Fix " Takashi Iwai
2026-01-23 15:47   ` Werner Sembach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox