* [PATCH][next] drm/i915/dp: Make read-only array bw_gbps static const
@ 2024-07-22 15:39 Colin Ian King
2024-07-24 10:05 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-07-22 15:39 UTC (permalink / raw)
To: Jani Nikula, Rodrigo Vivi, Joonas Lahtinen, Tvrtko Ursulin,
David Airlie, Daniel Vetter, intel-gfx, intel-xe, dri-devel
Cc: kernel-janitors, linux-kernel
Don't populate the read-only array bw_gbps on the stack at run time,
instead make it static const.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 59f11af3b0a1..a082ed8f5464 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3434,7 +3434,7 @@ static void intel_dp_get_pcon_dsc_cap(struct intel_dp *intel_dp)
static int intel_dp_pcon_get_frl_mask(u8 frl_bw_mask)
{
- int bw_gbps[] = {9, 18, 24, 32, 40, 48};
+ static const int bw_gbps[] = {9, 18, 24, 32, 40, 48};
int i;
for (i = ARRAY_SIZE(bw_gbps) - 1; i >= 0; i--) {
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH][next] drm/i915/dp: Make read-only array bw_gbps static const
2024-07-22 15:39 [PATCH][next] drm/i915/dp: Make read-only array bw_gbps static const Colin Ian King
@ 2024-07-24 10:05 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2024-07-24 10:05 UTC (permalink / raw)
To: Colin Ian King, Rodrigo Vivi, Joonas Lahtinen, Tvrtko Ursulin,
David Airlie, Daniel Vetter, intel-gfx, intel-xe, dri-devel
Cc: kernel-janitors, linux-kernel
On Mon, 22 Jul 2024, Colin Ian King <colin.i.king@gmail.com> wrote:
> Don't populate the read-only array bw_gbps on the stack at run time,
> instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Pushed to drm-intel-next, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 59f11af3b0a1..a082ed8f5464 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3434,7 +3434,7 @@ static void intel_dp_get_pcon_dsc_cap(struct intel_dp *intel_dp)
>
> static int intel_dp_pcon_get_frl_mask(u8 frl_bw_mask)
> {
> - int bw_gbps[] = {9, 18, 24, 32, 40, 48};
> + static const int bw_gbps[] = {9, 18, 24, 32, 40, 48};
> int i;
>
> for (i = ARRAY_SIZE(bw_gbps) - 1; i >= 0; i--) {
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-24 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-22 15:39 [PATCH][next] drm/i915/dp: Make read-only array bw_gbps static const Colin Ian King
2024-07-24 10:05 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox