From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Scott Wood <oss@buserror.net>,
Rashmica Gupta <rashmicy@gmail.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm: Move page table dump into powerpc subdirectory
Date: Thu, 13 Apr 2017 23:20:34 +1000 [thread overview]
Message-ID: <87fuhc8mvx.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170413124148.EB6C76E664@localhost.localdomain>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Page table dump is a powerpc specific thing, so it should
> appear in powerpc/ subdirectory of debugfs
It's not powerpc specific. x86, arm, arm64 and s390 all have it.
But, I notice we somehow got the name wrong :}
All the other arches call it "kernel_page_tables".
> - debugfs_file = debugfs_create_file("kernel_pagetables", 0400, NULL,
> - NULL, &ptdump_fops);
¯\_(ツ)_/¯
So we probably should rename it to match the other arches. I would take
a patch for that.
cheers
prev parent reply other threads:[~2017-04-13 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 12:41 [PATCH] powerpc/mm: Move page table dump into powerpc subdirectory Christophe Leroy
2017-04-13 13:20 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuhc8mvx.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=rashmicy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox