* [PATCH] ALSA: hda/cirrus_scodec_test: Don't select dependencies
@ 2025-04-09 11:45 Richard Fitzgerald
2025-04-09 12:55 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Richard Fitzgerald @ 2025-04-09 11:45 UTC (permalink / raw)
To: tiwai; +Cc: linux-sound, linux-kernel, patches
Depend on SND_HDA_CIRRUS_SCODEC and GPIOLIB instead of selecting them.
KUNIT_ALL_TESTS should only build tests that have satisfied dependencies
and test components that are already being built. It must not cause
other stuff to be added to the build.
Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/pci/hda/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index fb955a205d50..9c427270ff4f 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -96,9 +96,7 @@ config SND_HDA_CIRRUS_SCODEC
config SND_HDA_CIRRUS_SCODEC_KUNIT_TEST
tristate "KUnit test for Cirrus side-codec library" if !KUNIT_ALL_TESTS
- select SND_HDA_CIRRUS_SCODEC
- select GPIOLIB
- depends on KUNIT
+ depends on SND_HDA_CIRRUS_SCODEC && GPIOLIB && KUNIT
default KUNIT_ALL_TESTS
help
This builds KUnit tests for the cirrus side-codec library.
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/cirrus_scodec_test: Don't select dependencies
2025-04-09 11:45 [PATCH] ALSA: hda/cirrus_scodec_test: Don't select dependencies Richard Fitzgerald
@ 2025-04-09 12:55 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-04-09 12:55 UTC (permalink / raw)
To: Richard Fitzgerald; +Cc: tiwai, linux-sound, linux-kernel, patches
On Wed, 09 Apr 2025 13:45:20 +0200,
Richard Fitzgerald wrote:
>
> Depend on SND_HDA_CIRRUS_SCODEC and GPIOLIB instead of selecting them.
>
> KUNIT_ALL_TESTS should only build tests that have satisfied dependencies
> and test components that are already being built. It must not cause
> other stuff to be added to the build.
>
> Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test")
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-09 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-09 11:45 [PATCH] ALSA: hda/cirrus_scodec_test: Don't select dependencies Richard Fitzgerald
2025-04-09 12:55 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox