From: Arnaud Giersch <arnaud.giersch@free.fr>
To: linux-parport@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] parport: add parallel port support for SGI O2
Date: Wed, 25 Jan 2006 00:33:16 +0100 [thread overview]
Message-ID: <87hd7t5hhf.fsf@groumpf.homeip.net> (raw)
In-Reply-To: <87ek2ycy5q.fsf@groumpf.homeip.net> (Arnaud Giersch's message of "Tue, 24 Jan 2006 00:38:57 +0100")
Mardi 24 janvier 2006, vers 00:38:57 (+0100), j'ai écrit:
> I will correct the style.
[...]
> I will add a comment to explain it in the code.
[...]
> I did not realized that. I will try to correct the problem.
An updated version is available at
http://arnaud.giersch.free.fr/parport_ip32/parport_ip32-0.6.patch.gz
Since all changes are non-functional ones, I did not want to flood the
lists again with the full patch.
Changes are:
* Address comments from Andrew Morton <akpm_at_osdl.org>:
- Style: avoid single line "if" and "case" statements.
- Turn some printk() into pr_debug1(), so that they only exist
in debugging mode.
- Add a comment about "volatile".
- Add a comment about readsb() and writesb().
* Only define DEBUG_PARPORT_IP32 if it is not already defined.
* Remove the CVS $Id$ line.
Arnaud
prev parent reply other threads:[~2006-01-24 23:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 23:14 [PATCHv2] parport: add parallel port support for SGI O2 Arnaud Giersch
2006-01-23 6:24 ` Andrew Morton
2006-01-23 23:38 ` Arnaud Giersch
2006-01-24 23:33 ` Arnaud Giersch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hd7t5hhf.fsf@groumpf.homeip.net \
--to=arnaud.giersch@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox