* [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
@ 2024-10-28 22:38 kernel test robot
2024-10-29 21:18 ` Thomas Gleixner
0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2024-10-28 22:38 UTC (permalink / raw)
To: Vincenzo Frascino
Cc: oe-kbuild-all, linux-kernel, x86, Thomas Gleixner, Arnd Bergmann
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/vdso
head: d4a65302dd849fade9e2ca712826c35b8d068ecb
commit: efe8419ae78d65e83edc31aad74b605c12e7d60c [11/13] vdso: Introduce vdso/page.h
config: m68k-alldefconfig (https://download.01.org/0day-ci/archive/20241029/202410290639.TBG289SO-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241029/202410290639.TBG289SO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410290639.TBG289SO-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from arch/m68k/include/asm/page.h:9,
from arch/m68k/include/asm/thread_info.h:6,
from include/linux/thread_info.h:60,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from arch/m68k/include/asm/processor.h:11,
from include/linux/sched.h:13,
from arch/m68k/kernel/asm-offsets.c:15:
arch/m68k/include/asm/page_mm.h: In function 'virt_to_pfn':
include/vdso/page.h:13:25: error: 'CONFIG_PAGE_SHIFT' undeclared (first use in this function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
13 | #define PAGE_SHIFT CONFIG_PAGE_SHIFT
| ^~~~~~~~~~~~~~~~~
arch/m68k/include/asm/page_mm.h:125:31: note: in expansion of macro 'PAGE_SHIFT'
125 | return __pa(kaddr) >> PAGE_SHIFT;
| ^~~~~~~~~~
include/vdso/page.h:13:25: note: each undeclared identifier is reported only once for each function it appears in
13 | #define PAGE_SHIFT CONFIG_PAGE_SHIFT
| ^~~~~~~~~~~~~~~~~
arch/m68k/include/asm/page_mm.h:125:31: note: in expansion of macro 'PAGE_SHIFT'
125 | return __pa(kaddr) >> PAGE_SHIFT;
| ^~~~~~~~~~
arch/m68k/include/asm/page_mm.h: In function 'pfn_to_virt':
include/vdso/page.h:13:25: error: 'CONFIG_PAGE_SHIFT' undeclared (first use in this function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
13 | #define PAGE_SHIFT CONFIG_PAGE_SHIFT
| ^~~~~~~~~~~~~~~~~
arch/m68k/include/asm/page_mm.h:130:28: note: in expansion of macro 'PAGE_SHIFT'
130 | return __va(pfn << PAGE_SHIFT);
| ^~~~~~~~~~
include/asm-generic/getorder.h: In function 'get_order':
include/vdso/page.h:13:25: error: 'CONFIG_PAGE_SHIFT' undeclared (first use in this function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
13 | #define PAGE_SHIFT CONFIG_PAGE_SHIFT
| ^~~~~~~~~~~~~~~~~
include/asm-generic/getorder.h:33:48: note: in expansion of macro 'PAGE_SHIFT'
33 | return BITS_PER_LONG - PAGE_SHIFT;
| ^~~~~~~~~~
arch/m68k/include/asm/thread_info.h: At top level:
include/vdso/page.h:13:25: warning: "CONFIG_PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef]
13 | #define PAGE_SHIFT CONFIG_PAGE_SHIFT
| ^~~~~~~~~~~~~~~~~
arch/m68k/include/asm/thread_info.h:13:5: note: in expansion of macro 'PAGE_SHIFT'
13 | #if PAGE_SHIFT < 13
| ^~~~~~~~~~
arch/m68k/include/asm/thread_info.h: In function 'current_thread_info':
include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared (first use in this function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
15 | #define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~
arch/m68k/include/asm/thread_info.h:23:26: note: in expansion of macro 'PAGE_SIZE'
23 | #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER)
| ^~~~~~~~~
arch/m68k/include/asm/thread_info.h:51:27: note: in expansion of macro 'THREAD_SIZE'
51 | : "di" (~(THREAD_SIZE-1))
| ^~~~~~~~~~~
include/linux/mm_types_task.h: At top level:
include/vdso/page.h:15:39: warning: "CONFIG_PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef]
15 | #define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~
include/linux/mm_types_task.h:37:30: note: in expansion of macro 'PAGE_SIZE'
37 | #if (BITS_PER_LONG > 32) || (PAGE_SIZE >= 65536)
| ^~~~~~~~~
>> include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
15 | #define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~
arch/m68k/include/asm/thread_info.h:23:26: note: in expansion of macro 'PAGE_SIZE'
23 | #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER)
| ^~~~~~~~~
include/linux/sched.h:1890:29: note: in expansion of macro 'THREAD_SIZE'
1890 | unsigned long stack[THREAD_SIZE/sizeof(long)];
| ^~~~~~~~~~~
include/vdso/page.h:15:39: warning: "CONFIG_PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef]
15 | #define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~
include/linux/mm_types.h:547:6: note: in expansion of macro 'PAGE_SIZE'
547 | #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE)
| ^~~~~~~~~
In file included from include/vdso/const.h:5,
from include/linux/const.h:4,
from include/linux/bits.h:5,
from include/linux/ratelimit_types.h:5,
from include/linux/printk.h:9,
from include/asm-generic/bug.h:22,
from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13:
include/vdso/page.h:15:39: warning: "CONFIG_PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef]
15 | #define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~
include/uapi/linux/const.h:49:50: note: in definition of macro '__ALIGN_KERNEL_MASK'
49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
| ^~~~
include/linux/mm_types.h:524:41: note: in expansion of macro '__ALIGN_MASK'
524 | #define PAGE_FRAG_CACHE_MAX_SIZE __ALIGN_MASK(32768, ~PAGE_MASK)
| ^~~~~~~~~~~~
include/vdso/page.h:27:28: note: in expansion of macro 'PAGE_SIZE'
27 | #define PAGE_MASK (~(PAGE_SIZE - 1))
| ^~~~~~~~~
include/linux/mm_types.h:524:62: note: in expansion of macro 'PAGE_MASK'
524 | #define PAGE_FRAG_CACHE_MAX_SIZE __ALIGN_MASK(32768, ~PAGE_MASK)
| ^~~~~~~~~
include/linux/mm_types.h:547:18: note: in expansion of macro 'PAGE_FRAG_CACHE_MAX_SIZE'
547 | #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/vdso/page.h:15:39: warning: "CONFIG_PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef]
15 | #define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~
include/uapi/linux/const.h:49:61: note: in definition of macro '__ALIGN_KERNEL_MASK'
49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
| ^~~~
include/linux/mm_types.h:524:41: note: in expansion of macro '__ALIGN_MASK'
524 | #define PAGE_FRAG_CACHE_MAX_SIZE __ALIGN_MASK(32768, ~PAGE_MASK)
| ^~~~~~~~~~~~
include/vdso/page.h:27:28: note: in expansion of macro 'PAGE_SIZE'
27 | #define PAGE_MASK (~(PAGE_SIZE - 1))
| ^~~~~~~~~
include/linux/mm_types.h:524:62: note: in expansion of macro 'PAGE_MASK'
524 | #define PAGE_FRAG_CACHE_MAX_SIZE __ALIGN_MASK(32768, ~PAGE_MASK)
| ^~~~~~~~~
include/linux/mm_types.h:547:18: note: in expansion of macro 'PAGE_FRAG_CACHE_MAX_SIZE'
547 | #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE)
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/init.h:5,
from include/linux/printk.h:6:
>> include/vdso/page.h:13:25: error: expression in static assertion is not an integer
13 | #define PAGE_SHIFT CONFIG_PAGE_SHIFT
| ^~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/slab.h:695:1: note: in expansion of macro 'static_assert'
695 | static_assert(PAGE_SHIFT <= 20);
| ^~~~~~~~~~~~~
include/linux/slab.h:695:15: note: in expansion of macro 'PAGE_SHIFT'
695 | static_assert(PAGE_SHIFT <= 20);
| ^~~~~~~~~~
In file included from include/linux/irq.h:21,
from include/asm-generic/hardirq.h:17,
from ./arch/m68k/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:11,
from include/linux/interrupt.h:11,
from include/linux/kernel_stat.h:8,
from arch/m68k/kernel/asm-offsets.c:16:
include/linux/slab.h:809:33: warning: 'assume_aligned' attribute argument <erroneous-expression> is not an integer constant [-Wattributes]
809 | __assume_page_alignment __alloc_size(1);
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/slab.h:812:33: warning: 'assume_aligned' attribute argument <erroneous-expression> is not an integer constant [-Wattributes]
812 | __assume_page_alignment __alloc_size(1);
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/slab.h: In function 'kmalloc_noprof':
include/linux/slab.h:879:78: error: subscripted value is neither array nor pointer nor vector
879 | kmalloc_caches[kmalloc_type(flags, _RET_IP_)][index],
| ^
include/linux/slab.h:872:30: warning: variable 'index' set but not used [-Wunused-but-set-variable]
872 | unsigned int index;
| ^~~~~
include/linux/slab.h: In function 'kmalloc_node_noprof':
include/linux/slab.h:902:78: error: subscripted value is neither array nor pointer nor vector
902 | kmalloc_caches[kmalloc_type(flags, _RET_IP_)][index],
| ^
include/linux/slab.h:895:30: warning: variable 'index' set but not used [-Wunused-but-set-variable]
895 | unsigned int index;
| ^~~~~
make[3]: *** [scripts/Makefile.build:102: arch/m68k/kernel/asm-offsets.s] Error 1
make[3]: Target 'prepare' not remade because of errors.
make[2]: *** [Makefile:1203: prepare0] Error 2
make[2]: Target 'prepare' not remade because of errors.
make[1]: *** [Makefile:224: __sub-make] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:224: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +15 include/vdso/page.h
6
7 /*
8 * PAGE_SHIFT determines the page size.
9 *
10 * Note: This definition is required because PAGE_SHIFT is used
11 * in several places throuout the codebase.
12 */
> 13 #define PAGE_SHIFT CONFIG_PAGE_SHIFT
14
> 15 #define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT)
16
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
2024-10-28 22:38 [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'? kernel test robot
@ 2024-10-29 21:18 ` Thomas Gleixner
2024-10-29 22:05 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2024-10-29 21:18 UTC (permalink / raw)
To: kernel test robot, Vincenzo Frascino
Cc: oe-kbuild-all, linux-kernel, x86, Arnd Bergmann,
Geert Uytterhoeven
On Tue, Oct 29 2024 at 06:38, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/vdso
> head: d4a65302dd849fade9e2ca712826c35b8d068ecb
> commit: efe8419ae78d65e83edc31aad74b605c12e7d60c [11/13] vdso: Introduce vdso/page.h
> config: m68k-alldefconfig (https://download.01.org/0day-ci/archive/20241029/202410290639.TBG289SO-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241029/202410290639.TBG289SO-lkp@intel.com/reproduce)
> 6
> 7 /*
> 8 * PAGE_SHIFT determines the page size.
> 9 *
> 10 * Note: This definition is required because PAGE_SHIFT is used
> 11 * in several places throuout the codebase.
> 12 */
> > 13 #define PAGE_SHIFT CONFIG_PAGE_SHIFT
> 14
> > 15 #define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT)
> 16
That's actually not the culprit. The problem exists in mainline too. The
actual root cause is:
5394f1e9b687 ("arch: define CONFIG_PAGE_SIZE_*KB on all architectures")
The config has no CONFIG_PAGE_SHIFT because nothing selects a page size. The
the original code had:
if defined(CONFIG_SUN3) || defined(CONFIG_COLDFIRE)
#define PAGE_SHIFT 13
#else
#define PAGE_SHIFT 12
#endif
But the Kconfig magic changes made this depend on various other things.
The patch below cures it, but it needs an eyeball from Geert.
Thanks,
tglx
---
diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index cc26df907bfe..6f50fdc4dff2 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -85,15 +85,12 @@ config MMU
config MMU_MOTOROLA
bool
- select HAVE_PAGE_SIZE_4KB
config MMU_COLDFIRE
- select HAVE_PAGE_SIZE_8KB
bool
config MMU_SUN3
bool
- select HAVE_PAGE_SIZE_8KB
depends on MMU && !MMU_MOTOROLA && !MMU_COLDFIRE
config ARCH_SUPPORTS_KEXEC
diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index c777a129768a..4d16215e7e45 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -21,6 +21,8 @@ choice
config M68KCLASSIC
bool "Classic M68K CPU family support"
select HAVE_ARCH_PFN_VALID
+ select HAVE_PAGE_SIZE_4KB if !SUN3
+ select HAVE_PAGE_SIZE_8KB if SUN3
config COLDFIRE
bool "Coldfire CPU family support"
@@ -30,7 +32,7 @@ config COLDFIRE
select GENERIC_CSUM
select GPIOLIB
select HAVE_LEGACY_CLK
- select HAVE_PAGE_SIZE_8KB if !MMU
+ select HAVE_PAGE_SIZE_8KB
endchoice
@@ -46,7 +48,6 @@ config M68000
select GENERIC_CSUM
select CPU_NO_EFFICIENT_FFS
select HAVE_ARCH_HASH
- select HAVE_PAGE_SIZE_4KB
select LEGACY_TIMER_TICK
help
The Freescale (was Motorola) 68000 CPU is the first generation of
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
2024-10-29 21:18 ` Thomas Gleixner
@ 2024-10-29 22:05 ` Arnd Bergmann
2024-10-29 23:45 ` Thomas Gleixner
2024-10-30 8:49 ` Geert Uytterhoeven
0 siblings, 2 replies; 6+ messages in thread
From: Arnd Bergmann @ 2024-10-29 22:05 UTC (permalink / raw)
To: Thomas Gleixner, kernel test robot, Vincenzo Frascino
Cc: oe-kbuild-all, linux-kernel, x86, Geert Uytterhoeven
On Tue, Oct 29, 2024, at 21:18, Thomas Gleixner wrote:
> On Tue, Oct 29 2024 at 06:38, kernel test robot wrote:
>
> That's actually not the culprit. The problem exists in mainline too. The
> actual root cause is:
>
> 5394f1e9b687 ("arch: define CONFIG_PAGE_SIZE_*KB on all architectures")
>
> The config has no CONFIG_PAGE_SHIFT because nothing selects a page size. The
> the original code had:
>
> if defined(CONFIG_SUN3) || defined(CONFIG_COLDFIRE)
> #define PAGE_SHIFT 13
> #else
> #define PAGE_SHIFT 12
> #endif
>
> But the Kconfig magic changes made this depend on various other things.
>
> The patch below cures it, but it needs an eyeball from Geert.
I have previously suggested a similar but more extensive patch
to address the problem:
https://lore.kernel.org/all/CAMuHMdVC-FUSA5C9aNrvP3=RaRWrchhUEC5UYcSGMz_ep1PEhg@mail.gmail.com/
I can rebase that one if Geert still wants it. I think I sent
an updated version somewhere but can't find it now.
> --- a/arch/m68k/Kconfig.cpu
> +++ b/arch/m68k/Kconfig.cpu
> @@ -21,6 +21,8 @@ choice
> config M68KCLASSIC
> bool "Classic M68K CPU family support"
> select HAVE_ARCH_PFN_VALID
> + select HAVE_PAGE_SIZE_4KB if !SUN3
> + select HAVE_PAGE_SIZE_8KB if SUN3
>
> config COLDFIRE
> bool "Coldfire CPU family support"
> @@ -30,7 +32,7 @@ config COLDFIRE
> select GENERIC_CSUM
> select GPIOLIB
> select HAVE_LEGACY_CLK
> - select HAVE_PAGE_SIZE_8KB if !MMU
> + select HAVE_PAGE_SIZE_8KB
>
> endchoice
>
> @@ -46,7 +48,6 @@ config M68000
> select GENERIC_CSUM
> select CPU_NO_EFFICIENT_FFS
> select HAVE_ARCH_HASH
> - select HAVE_PAGE_SIZE_4KB
> select LEGACY_TIMER_TICK
> help
> The Freescale (was Motorola) 68000 CPU is the first generation of
Part of the problem here is that this simpler patch
then just causes different build failures for the
same configurations, since m68k kernels cannot successfully
build when no platform is selected.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
2024-10-29 22:05 ` Arnd Bergmann
@ 2024-10-29 23:45 ` Thomas Gleixner
2024-10-30 8:49 ` Geert Uytterhoeven
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2024-10-29 23:45 UTC (permalink / raw)
To: Arnd Bergmann, kernel test robot, Vincenzo Frascino
Cc: oe-kbuild-all, linux-kernel, x86, Geert Uytterhoeven
On Tue, Oct 29 2024 at 22:05, Arnd Bergmann wrote:
> On Tue, Oct 29, 2024, at 21:18, Thomas Gleixner wrote:
>
> Part of the problem here is that this simpler patch
> then just causes different build failures for the
> same configurations, since m68k kernels cannot successfully
> build when no platform is selected.
But that's a problem which existed before all of that PAGE* changes,
right?
Geert, can you please take care of that magic Kconfig maze in m68k as
I'm completely lost how that is supposed to work?
Thanks,
tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
2024-10-29 22:05 ` Arnd Bergmann
2024-10-29 23:45 ` Thomas Gleixner
@ 2024-10-30 8:49 ` Geert Uytterhoeven
2024-10-30 9:05 ` Arnd Bergmann
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-10-30 8:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Thomas Gleixner, kernel test robot, Vincenzo Frascino,
oe-kbuild-all, linux-kernel, x86
Hi Arnd,
On Tue, Oct 29, 2024 at 11:05 PM Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Oct 29, 2024, at 21:18, Thomas Gleixner wrote:
> > On Tue, Oct 29 2024 at 06:38, kernel test robot wrote:
> > That's actually not the culprit. The problem exists in mainline too. The
> > actual root cause is:
> >
> > 5394f1e9b687 ("arch: define CONFIG_PAGE_SIZE_*KB on all architectures")
> >
> > The config has no CONFIG_PAGE_SHIFT because nothing selects a page size. The
> > the original code had:
> >
> > if defined(CONFIG_SUN3) || defined(CONFIG_COLDFIRE)
> > #define PAGE_SHIFT 13
> > #else
> > #define PAGE_SHIFT 12
> > #endif
> >
> > But the Kconfig magic changes made this depend on various other things.
> >
> > The patch below cures it, but it needs an eyeball from Geert.
>
> I have previously suggested a similar but more extensive patch
> to address the problem:
>
> https://lore.kernel.org/all/CAMuHMdVC-FUSA5C9aNrvP3=RaRWrchhUEC5UYcSGMz_ep1PEhg@mail.gmail.com/
>
> I can rebase that one if Geert still wants it. I think I sent
I am still interested ;-)
> an updated version somewhere but can't find it now.
AFAIK you haven't, so there are still outstanding review comments on
the last version you sent...
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'?
2024-10-30 8:49 ` Geert Uytterhoeven
@ 2024-10-30 9:05 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2024-10-30 9:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Thomas Gleixner, kernel test robot, Vincenzo Frascino,
oe-kbuild-all, linux-kernel, x86
On Wed, Oct 30, 2024, at 08:49, Geert Uytterhoeven wrote:
> On Tue, Oct 29, 2024 at 11:05 PM Arnd Bergmann <arnd@arndb.de> wrote:
>> On Tue, Oct 29, 2024, at 21:18, Thomas Gleixner wrote:
>> I have previously suggested a similar but more extensive patch
>> to address the problem:
>>
>> https://lore.kernel.org/all/CAMuHMdVC-FUSA5C9aNrvP3=RaRWrchhUEC5UYcSGMz_ep1PEhg@mail.gmail.com/
>>
>> I can rebase that one if Geert still wants it. I think I sent
>
> I am still interested ;-)
>
>> an updated version somewhere but can't find it now.
>
> AFAIK you haven't, so there are still outstanding review comments on
> the last version you sent...
> Thanks!
Ok, sorry it slipped through, I'll send an updated version
later today then.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-30 9:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-28 22:38 [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'? kernel test robot
2024-10-29 21:18 ` Thomas Gleixner
2024-10-29 22:05 ` Arnd Bergmann
2024-10-29 23:45 ` Thomas Gleixner
2024-10-30 8:49 ` Geert Uytterhoeven
2024-10-30 9:05 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox