public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR
@ 2024-01-26  8:09 Chhayly Leang
  2024-01-30 11:05 ` Takashi Iwai
  2024-01-30 13:10 ` Takashi Iwai
  0 siblings, 2 replies; 4+ messages in thread
From: Chhayly Leang @ 2024-01-26  8:09 UTC (permalink / raw)
  To: Stefan Binding, Takashi Iwai, patches
  Cc: James Schulman, David Rhodes, Richard Fitzgerald, Jaroslav Kysela,
	linux-sound, linux-kernel, Chhayly Leang

Adds sound support for ASUS Zenbook UM3402YAR with missing DSD

Signed-off-by: Chhayly Leang <clw.leang@gmail.com>
---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 35277ce890a..2af083183d8 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+	{ "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
 	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "10431683", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR
  2024-01-26  8:09 [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR Chhayly Leang
@ 2024-01-30 11:05 ` Takashi Iwai
  2024-01-30 11:19   ` Stefan Binding
  2024-01-30 13:10 ` Takashi Iwai
  1 sibling, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2024-01-30 11:05 UTC (permalink / raw)
  To: Chhayly Leang
  Cc: Stefan Binding, Takashi Iwai, patches, James Schulman,
	David Rhodes, Richard Fitzgerald, Jaroslav Kysela, linux-sound,
	linux-kernel

On Fri, 26 Jan 2024 09:09:12 +0100,
Chhayly Leang wrote:
> 
> Adds sound support for ASUS Zenbook UM3402YAR with missing DSD
> 
> Signed-off-by: Chhayly Leang <clw.leang@gmail.com>

Yet another missing entry; can Cirrus people review this before I
merge?


thanks,

Takashi

> ---
>  sound/pci/hda/cs35l41_hda_property.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
> index 35277ce890a..2af083183d8 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
>  	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
>  	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
>  	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> +	{ "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
>  	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
>  	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
>  	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> @@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
>  	{ "CSC3551", "10431533", generic_dsd_config },
>  	{ "CSC3551", "10431573", generic_dsd_config },
>  	{ "CSC3551", "10431663", generic_dsd_config },
> +	{ "CSC3551", "10431683", generic_dsd_config },
>  	{ "CSC3551", "104316D3", generic_dsd_config },
>  	{ "CSC3551", "104316F3", generic_dsd_config },
>  	{ "CSC3551", "104317F3", generic_dsd_config },
> -- 
> 2.42.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR
  2024-01-30 11:05 ` Takashi Iwai
@ 2024-01-30 11:19   ` Stefan Binding
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Binding @ 2024-01-30 11:19 UTC (permalink / raw)
  To: 'Takashi Iwai', 'Chhayly Leang'
  Cc: 'Takashi Iwai', patches, 'James Schulman',
	'David Rhodes', 'Richard Fitzgerald',
	'Jaroslav Kysela', linux-sound, linux-kernel

Hi,

> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Tuesday, January 30, 2024 11:06 AM
> To: Chhayly Leang <clw.leang@gmail.com>
> Cc: Stefan Binding <sbinding@opensource.cirrus.com>; Takashi Iwai
> <tiwai@suse.com>; patches@opensource.cirrus.com; James Schulman
> <james.schulman@cirrus.com>; David Rhodes
> <david.rhodes@cirrus.com>; Richard Fitzgerald
> <rf@opensource.cirrus.com>; Jaroslav Kysela <perex@perex.cz>; linux-
> sound@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook
> UM3402YAR
> 
> On Fri, 26 Jan 2024 09:09:12 +0100,
> Chhayly Leang wrote:
> >
> > Adds sound support for ASUS Zenbook UM3402YAR with missing DSD
> >
> > Signed-off-by: Chhayly Leang <clw.leang@gmail.com>
> 
> Yet another missing entry; can Cirrus people review this before I
> merge?

Looks good to me.

Thanks,
Stefan

> 
> 
> thanks,
> 
> Takashi
> 
> > ---
> >  sound/pci/hda/cs35l41_hda_property.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> > index 35277ce890a..2af083183d8 100644
> > --- a/sound/pci/hda/cs35l41_hda_property.c
> > +++ b/sound/pci/hda/cs35l41_hda_property.c
> > @@ -76,6 +76,7 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
> >  	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4500, 24 },
> >  	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, 2, 0, 1000, 4500, 24 },
> >  	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, -1, 0, 1000, 4500, 24 },
> > +	{ "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 0, 0, 0 },
> >  	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, 2, 0, 0, 0, 0 },
> >  	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, 2, 0, 0, 0, 0 },
> >  	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4500, 24 },
> > @@ -410,6 +411,7 @@ static const struct cs35l41_prop_model
> cs35l41_prop_model_table[] = {
> >  	{ "CSC3551", "10431533", generic_dsd_config },
> >  	{ "CSC3551", "10431573", generic_dsd_config },
> >  	{ "CSC3551", "10431663", generic_dsd_config },
> > +	{ "CSC3551", "10431683", generic_dsd_config },
> >  	{ "CSC3551", "104316D3", generic_dsd_config },
> >  	{ "CSC3551", "104316F3", generic_dsd_config },
> >  	{ "CSC3551", "104317F3", generic_dsd_config },
> > --
> > 2.42.0
> >



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR
  2024-01-26  8:09 [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR Chhayly Leang
  2024-01-30 11:05 ` Takashi Iwai
@ 2024-01-30 13:10 ` Takashi Iwai
  1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2024-01-30 13:10 UTC (permalink / raw)
  To: Chhayly Leang
  Cc: Stefan Binding, Takashi Iwai, patches, James Schulman,
	David Rhodes, Richard Fitzgerald, Jaroslav Kysela, linux-sound,
	linux-kernel

On Fri, 26 Jan 2024 09:09:12 +0100,
Chhayly Leang wrote:
> 
> Adds sound support for ASUS Zenbook UM3402YAR with missing DSD
> 
> Signed-off-by: Chhayly Leang <clw.leang@gmail.com>

Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-01-30 13:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-26  8:09 [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR Chhayly Leang
2024-01-30 11:05 ` Takashi Iwai
2024-01-30 11:19   ` Stefan Binding
2024-01-30 13:10 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox