From: Peter Korsgaard <peter@korsgaard.com>
To: Haowen Bai <baihaowen@meizu.com>
Cc: <santoshkumar.yadav@barco.com>, <peter.korsgaard@barco.com>,
<hdegoede@redhat.com>, <markgross@kernel.org>,
<platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: barco-p50-gpio: Fix duplicate included inux/io.h
Date: Wed, 23 Mar 2022 08:21:56 +0100 [thread overview]
Message-ID: <87ils5f817.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1648006312-29460-1-git-send-email-baihaowen@meizu.com> (Haowen Bai's message of "Wed, 23 Mar 2022 11:31:52 +0800")
>>>>> "Haowen" == Haowen Bai <baihaowen@meizu.com> writes:
> Clean up the following includecheck warning:
> drivers/platform/x86/barco-p50-gpio.c: linux/io.h is included more than once.
> No functional change.
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e3..bb8ed8e 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>
It would be nicer to drop the io.h include higher up to keep the
(almost) alphabetical ordering.
Other than that:
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2022-03-23 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 3:31 [PATCH] platform/x86: barco-p50-gpio: Fix duplicate included inux/io.h Haowen Bai
2022-03-23 7:21 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ils5f817.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=baihaowen@meizu.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=peter.korsgaard@barco.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=santoshkumar.yadav@barco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox