* [PATCH] platform/x86: barco-p50-gpio: Fix duplicate included inux/io.h
@ 2022-03-23 3:31 Haowen Bai
2022-03-23 7:21 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-03-23 3:31 UTC (permalink / raw)
To: santoshkumar.yadav, peter.korsgaard, hdegoede, markgross
Cc: platform-driver-x86, linux-kernel, Haowen Bai
Clean up the following includecheck warning:
drivers/platform/x86/barco-p50-gpio.c: linux/io.h is included more than once.
No functional change.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/platform/x86/barco-p50-gpio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
index f5c72e3..bb8ed8e 100644
--- a/drivers/platform/x86/barco-p50-gpio.c
+++ b/drivers/platform/x86/barco-p50-gpio.c
@@ -14,7 +14,6 @@
#include <linux/delay.h>
#include <linux/dmi.h>
#include <linux/err.h>
-#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/module.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: barco-p50-gpio: Fix duplicate included inux/io.h
2022-03-23 3:31 [PATCH] platform/x86: barco-p50-gpio: Fix duplicate included inux/io.h Haowen Bai
@ 2022-03-23 7:21 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2022-03-23 7:21 UTC (permalink / raw)
To: Haowen Bai
Cc: santoshkumar.yadav, peter.korsgaard, hdegoede, markgross,
platform-driver-x86, linux-kernel
>>>>> "Haowen" == Haowen Bai <baihaowen@meizu.com> writes:
> Clean up the following includecheck warning:
> drivers/platform/x86/barco-p50-gpio.c: linux/io.h is included more than once.
> No functional change.
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e3..bb8ed8e 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>
It would be nicer to drop the io.h include higher up to keep the
(almost) alphabetical ordering.
Other than that:
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-23 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-23 3:31 [PATCH] platform/x86: barco-p50-gpio: Fix duplicate included inux/io.h Haowen Bai
2022-03-23 7:21 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox