From: Nam Cao <namcao@linutronix.de>
To: Gabriele Monaco <gmonaco@redhat.com>,
schuster.simon@siemens-energy.com,
Steven Rostedt <rostedt@goodmis.org>,
Christian Brauner <brauner@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags
Date: Wed, 10 Sep 2025 09:43:39 +0200 [thread overview]
Message-ID: <87jz26ah1w.fsf@yellow.woof> (raw)
In-Reply-To: <93a46874ceadf0080891e06d930336e120f2d753.camel@redhat.com>
Gabriele Monaco <gmonaco@redhat.com> writes:
> On Thu, 2025-09-04 at 13:36 +0200, Simon Schuster via B4 Relay wrote:
>> From: Simon Schuster <schuster.simon@siemens-energy.com>
>>
>> Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64
>> across
>> calltree") the task_newtask trace event exposes clone_flags as u64 to
>> its callbacks.
>>
>> However, ltl_monitor was not adapted, resulting in a faulty callback.
>> This also resulted in an lkp build warning due to
>> -Wincompatible-pointer-types.
>>
>
> Looks good to me, thanks!
>
> Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>
>
> Adding Nam (author of LTL) to the loop.
Acked-by: Nam Cao <namcao@linutronix.de>
I see no problem merging this to vfs, if vfs folks want that.
Nam
next prev parent reply other threads:[~2025-09-10 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 11:36 [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags Simon Schuster via B4 Relay
2025-09-09 11:06 ` Gabriele Monaco
2025-09-10 7:43 ` Nam Cao [this message]
2025-09-10 8:05 ` David Hildenbrand
2025-09-15 14:37 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz26ah1w.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=rostedt@goodmis.org \
--cc=schuster.simon@siemens-energy.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox