[PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags

[PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags

[Simon Schuster via B4 Relay]

From: Simon Schuster <schuster.simon@siemens-energy.com>

Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64 across
calltree") the task_newtask trace event exposes clone_flags as u64 to
its callbacks.

However, ltl_monitor was not adapted, resulting in a faulty callback.
This also resulted in an lkp build warning due to
-Wincompatible-pointer-types.

Fixes: edd3cb05c00a ("copy_process: pass clone_flags as u64 across calltree")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/lkml/20250904113334.18822d43@canb.auug.org.au/
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509040134.bQVbm7ja-lkp@intel.com/
Signed-off-by: Simon Schuster <schuster.simon@siemens-energy.com>
---
I did further search for other in-tree users of the task_newtask
callback, but the trace macros make it a bit harder. Yet, as far as I
could see, there are none, so this patch hopefully resolves the problem
for good. The other matches all relate to "tp_btf/task_newtask", which
seems to be unaffected.

With this patch, ARCH=S390 allmodconfig -- that originally tripped the
LKP builds -- now builds without further -Wincompatible-pointer-types
warnings.

Sorry for causing this trouble, and thanks to Stephen Rothwell for
testing/reporting.
---
 include/rv/ltl_monitor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/rv/ltl_monitor.h b/include/rv/ltl_monitor.h
index 67031a774e3d..5368cf5fd623 100644
--- a/include/rv/ltl_monitor.h
+++ b/include/rv/ltl_monitor.h
@@ -56,7 +56,7 @@ static void ltl_task_init(struct task_struct *task, bool task_creation)
 	ltl_atoms_fetch(task, mon);
 }
 
-static void handle_task_newtask(void *data, struct task_struct *task, unsigned long flags)
+static void handle_task_newtask(void *data, struct task_struct *task, u64 flags)
 {
 	ltl_task_init(task, true);
 }

---
base-commit: edd3cb05c00a040dc72bed20b14b5ba865188bce
change-id: 20250904-trace-task-newtask-fix-callbacks-b158634c59da

Best regards,
-- 
Simon Schuster <schuster.simon@siemens-energy.com>

Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags

[Gabriele Monaco]

On Thu, 2025-09-04 at 13:36 +0200, Simon Schuster via B4 Relay wrote:
> From: Simon Schuster <schuster.simon@siemens-energy.com>
> 
> Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64
> across
> calltree") the task_newtask trace event exposes clone_flags as u64 to
> its callbacks.
> 
> However, ltl_monitor was not adapted, resulting in a faulty callback.
> This also resulted in an lkp build warning due to
> -Wincompatible-pointer-types.
> 

Looks good to me, thanks!

Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>

Adding Nam (author of LTL) to the loop.

Gabriele

> Fixes: edd3cb05c00a ("copy_process: pass clone_flags as u64 across
> calltree")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes:
> https://lore.kernel.org/lkml/20250904113334.18822d43@canb.auug.org.au/
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202509040134.bQVbm7ja-lkp@intel.com/
> Signed-off-by: Simon Schuster <schuster.simon@siemens-energy.com>
> ---
> I did further search for other in-tree users of the task_newtask
> callback, but the trace macros make it a bit harder. Yet, as far as I
> could see, there are none, so this patch hopefully resolves the
> problem
> for good. The other matches all relate to "tp_btf/task_newtask",
> which
> seems to be unaffected.
> 
> With this patch, ARCH=S390 allmodconfig -- that originally tripped
> the
> LKP builds -- now builds without further -Wincompatible-pointer-types
> warnings.
> 
> Sorry for causing this trouble, and thanks to Stephen Rothwell for
> testing/reporting.
> ---
>  include/rv/ltl_monitor.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/rv/ltl_monitor.h b/include/rv/ltl_monitor.h
> index 67031a774e3d..5368cf5fd623 100644
> --- a/include/rv/ltl_monitor.h
> +++ b/include/rv/ltl_monitor.h
> @@ -56,7 +56,7 @@ static void ltl_task_init(struct task_struct *task,
> bool task_creation)
>  	ltl_atoms_fetch(task, mon);
>  }
>  
> -static void handle_task_newtask(void *data, struct task_struct
> *task, unsigned long flags)
> +static void handle_task_newtask(void *data, struct task_struct
> *task, u64 flags)
>  {
>  	ltl_task_init(task, true);
>  }
> 
> ---
> base-commit: edd3cb05c00a040dc72bed20b14b5ba865188bce
> change-id: 20250904-trace-task-newtask-fix-callbacks-b158634c59da
> 
> Best regards,

Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags

[Nam Cao]

Gabriele Monaco <gmonaco@redhat.com> writes:
> On Thu, 2025-09-04 at 13:36 +0200, Simon Schuster via B4 Relay wrote:
>> From: Simon Schuster <schuster.simon@siemens-energy.com>
>> 
>> Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64
>> across
>> calltree") the task_newtask trace event exposes clone_flags as u64 to
>> its callbacks.
>> 
>> However, ltl_monitor was not adapted, resulting in a faulty callback.
>> This also resulted in an lkp build warning due to
>> -Wincompatible-pointer-types.
>> 
>
> Looks good to me, thanks!
>
> Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>
>
> Adding Nam (author of LTL) to the loop.

Acked-by: Nam Cao <namcao@linutronix.de>

I see no problem merging this to vfs, if vfs folks want that.

Nam

Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags

[David Hildenbrand]

On 04.09.25 13:36, Simon Schuster via B4 Relay wrote:
> From: Simon Schuster <schuster.simon@siemens-energy.com>
> 
> Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64 across
> calltree") the task_newtask trace event exposes clone_flags as u64 to
> its callbacks.
> 
> However, ltl_monitor was not adapted, resulting in a faulty callback.
> This also resulted in an lkp build warning due to
> -Wincompatible-pointer-types.
> 
> Fixes: edd3cb05c00a ("copy_process: pass clone_flags as u64 across calltree")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/lkml/20250904113334.18822d43@canb.auug.org.au/
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509040134.bQVbm7ja-lkp@intel.com/
> Signed-off-by: Simon Schuster <schuster.simon@siemens-energy.com>
> ---
> I did further search for other in-tree users of the task_newtask
> callback, but the trace macros make it a bit harder. Yet, as far as I
> could see, there are none, so this patch hopefully resolves the problem
> for good. The other matches all relate to "tp_btf/task_newtask", which
> seems to be unaffected.
> 
> With this patch, ARCH=S390 allmodconfig -- that originally tripped the
> LKP builds -- now builds without further -Wincompatible-pointer-types
> warnings.
> 
> Sorry for causing this trouble, and thanks to Stephen Rothwell for
> testing/reporting.
> ---

Not a stable commit id I think, so it should be squashed into the 
original one.

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers

David / dhildenb

Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags

[Christian Brauner]

On Thu, 04 Sep 2025 13:36:52 +0200, Simon Schuster wrote:
> Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64 across
> calltree") the task_newtask trace event exposes clone_flags as u64 to
> its callbacks.
> 
> However, ltl_monitor was not adapted, resulting in a faulty callback.
> This also resulted in an lkp build warning due to
> -Wincompatible-pointer-types.
> 
> [...]

Applied to the kernel-6.18.clone3 branch of the vfs/vfs.git tree.
Patches in the kernel-6.18.clone3 branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: kernel-6.18.clone3

[1/1] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags
      https://git.kernel.org/vfs/vfs/c/02bf8f2f7ccb