* [PATCH] drm/amdkfd: Make process queues logs less verbose
@ 2020-02-01 23:11 Julian Sax
2020-02-01 23:37 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Julian Sax @ 2020-02-01 23:11 UTC (permalink / raw)
To: amd-gfx
Cc: Julian Sax, Felix Kuehling, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
During normal usage, especially if jobs are started and stopped in rapid
succession, the kernel log is filled with messages like this:
[38732.522910] Restoring PASID 0x8003 queues
[38732.666767] Evicting PASID 0x8003 queues
[38732.714074] Restoring PASID 0x8003 queues
[38732.815633] Evicting PASID 0x8003 queues
[38732.834961] Restoring PASID 0x8003 queues
[38732.840536] Evicting PASID 0x8003 queues
[38732.869846] Restoring PASID 0x8003 queues
[38732.893655] Evicting PASID 0x8003 queues
[38732.927975] Restoring PASID 0x8003 queues
According to [1], these messages are expected, but they carry little
value for the end user, so turn them into debug messages.
[1] https://github.com/RadeonOpenCompute/ROCm/issues/343
Signed-off-by: Julian Sax <jsbc@gmx.de>
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index 984c2f2b24b6..3dc0e8c3b91b 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm,
goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
+ pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
pdd->process->pasid);
/* Mark all queues as evicted. Deactivate all active queues on
@@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
+ pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
pdd->process->pasid);
/* Mark all queues as evicted. Deactivate all active queues on
@@ -696,7 +696,7 @@ static int restore_process_queues_nocpsch(struct device_queue_manager *dqm,
goto out;
}
- pr_info_ratelimited("Restoring PASID 0x%x queues\n",
+ pr_debug_ratelimited("Restoring PASID 0x%x queues\n",
pdd->process->pasid);
/* Update PD Base in QPD */
@@ -772,7 +772,7 @@ static int restore_process_queues_cpsch(struct device_queue_manager *dqm,
goto out;
}
- pr_info_ratelimited("Restoring PASID 0x%x queues\n",
+ pr_debug_ratelimited("Restoring PASID 0x%x queues\n",
pdd->process->pasid);
/* Update PD Base in QPD */
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdkfd: Make process queues logs less verbose
2020-02-01 23:11 [PATCH] drm/amdkfd: Make process queues logs less verbose Julian Sax
@ 2020-02-01 23:37 ` Joe Perches
2020-02-02 0:14 ` Julian Sax
2020-02-02 0:18 ` [PATCH v2] " Julian Sax
0 siblings, 2 replies; 4+ messages in thread
From: Joe Perches @ 2020-02-01 23:37 UTC (permalink / raw)
To: Julian Sax, amd-gfx
Cc: Felix Kuehling, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
On Sun, 2020-02-02 at 00:11 +0100, Julian Sax wrote:
> During normal usage, especially if jobs are started and stopped in rapid
> succession, the kernel log is filled with messages like this:
>
> [38732.522910] Restoring PASID 0x8003 queues
> [38732.666767] Evicting PASID 0x8003 queues
> [38732.714074] Restoring PASID 0x8003 queues
> [38732.815633] Evicting PASID 0x8003 queues
> [38732.834961] Restoring PASID 0x8003 queues
> [38732.840536] Evicting PASID 0x8003 queues
> [38732.869846] Restoring PASID 0x8003 queues
> [38732.893655] Evicting PASID 0x8003 queues
> [38732.927975] Restoring PASID 0x8003 queues
>
> According to [1], these messages are expected, but they carry little
> value for the end user, so turn them into debug messages.
>
> [1] https://github.com/RadeonOpenCompute/ROCm/issues/343
trivia:
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
[]
> @@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm,
> goto out;
>
> pdd = qpd_to_pdd(qpd);
> - pr_info_ratelimited("Evicting PASID 0x%x queues\n",
> + pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
> pdd->process->pasid);
It would be nicer to realign all the subsequent lines in a
single statement to the now moved open parenthesis.
>
> /* Mark all queues as evicted. Deactivate all active queues on
> @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
> goto out;
>
> pdd = qpd_to_pdd(qpd);
> - pr_info_ratelimited("Evicting PASID 0x%x queues\n",
> + pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
> pdd->process->pasid);
etc...
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdkfd: Make process queues logs less verbose
2020-02-01 23:37 ` Joe Perches
@ 2020-02-02 0:14 ` Julian Sax
2020-02-02 0:18 ` [PATCH v2] " Julian Sax
1 sibling, 0 replies; 4+ messages in thread
From: Julian Sax @ 2020-02-02 0:14 UTC (permalink / raw)
To: Joe Perches
Cc: amd-gfx, Felix Kuehling, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
Joe Perches <joe@perches.com> writes:
> On Sun, 2020-02-02 at 00:11 +0100, Julian Sax wrote:
>> During normal usage, especially if jobs are started and stopped in rapid
>> succession, the kernel log is filled with messages like this:
>>
>> [38732.522910] Restoring PASID 0x8003 queues
>> [38732.666767] Evicting PASID 0x8003 queues
>> [38732.714074] Restoring PASID 0x8003 queues
>> [38732.815633] Evicting PASID 0x8003 queues
>> [38732.834961] Restoring PASID 0x8003 queues
>> [38732.840536] Evicting PASID 0x8003 queues
>> [38732.869846] Restoring PASID 0x8003 queues
>> [38732.893655] Evicting PASID 0x8003 queues
>> [38732.927975] Restoring PASID 0x8003 queues
>>
>> According to [1], these messages are expected, but they carry little
>> value for the end user, so turn them into debug messages.
>>
>> [1] https://github.com/RadeonOpenCompute/ROCm/issues/343
>
> trivia:
>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> []
>> @@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm,
>> goto out;
>>
>> pdd = qpd_to_pdd(qpd);
>> - pr_info_ratelimited("Evicting PASID 0x%x queues\n",
>> + pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
>> pdd->process->pasid);
>
> It would be nicer to realign all the subsequent lines in a
> single statement to the now moved open parenthesis.
>
>>
>> /* Mark all queues as evicted. Deactivate all active queues on
>> @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
>> goto out;
>>
>> pdd = qpd_to_pdd(qpd);
>> - pr_info_ratelimited("Evicting PASID 0x%x queues\n",
>> + pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
>> pdd->process->pasid);
>
> etc...
Yeah, absolutely, thanks for pointing that out. v2 coming shortly.
Julian
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] drm/amdkfd: Make process queues logs less verbose
2020-02-01 23:37 ` Joe Perches
2020-02-02 0:14 ` Julian Sax
@ 2020-02-02 0:18 ` Julian Sax
1 sibling, 0 replies; 4+ messages in thread
From: Julian Sax @ 2020-02-02 0:18 UTC (permalink / raw)
To: Joe Perches
Cc: Julian Sax, Felix Kuehling, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter, amd-gfx,
dri-devel, linux-kernel
During normal usage, especially if jobs are started and stopped in rapid
succession, the kernel log is filled with messages like this:
[38732.522910] Restoring PASID 0x8003 queues
[38732.666767] Evicting PASID 0x8003 queues
[38732.714074] Restoring PASID 0x8003 queues
[38732.815633] Evicting PASID 0x8003 queues
[38732.834961] Restoring PASID 0x8003 queues
[38732.840536] Evicting PASID 0x8003 queues
[38732.869846] Restoring PASID 0x8003 queues
[38732.893655] Evicting PASID 0x8003 queues
[38732.927975] Restoring PASID 0x8003 queues
According to [1], these messages are expected, but they carry little
value for the end user, so turn them into debug messages.
[1] https://github.com/RadeonOpenCompute/ROCm/issues/343
Signed-off-by: Julian Sax <jsbc@gmx.de>
---
v2: fixed indenting of following lines
.../drm/amd/amdkfd/kfd_device_queue_manager.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index 2870553a2ce0..13bd588c4419 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -604,8 +604,8 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm,
goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
- pdd->process->pasid);
+ pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
+ pdd->process->pasid);
/* Mark all queues as evicted. Deactivate all active queues on
* the qpd.
@@ -650,8 +650,8 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
- pdd->process->pasid);
+ pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
+ pdd->process->pasid);
/* Mark all queues as evicted. Deactivate all active queues on
* the qpd.
@@ -696,8 +696,8 @@ static int restore_process_queues_nocpsch(struct device_queue_manager *dqm,
goto out;
}
- pr_info_ratelimited("Restoring PASID 0x%x queues\n",
- pdd->process->pasid);
+ pr_debug_ratelimited("Restoring PASID 0x%x queues\n",
+ pdd->process->pasid);
/* Update PD Base in QPD */
qpd->page_table_base = pd_base;
@@ -772,8 +772,8 @@ static int restore_process_queues_cpsch(struct device_queue_manager *dqm,
goto out;
}
- pr_info_ratelimited("Restoring PASID 0x%x queues\n",
- pdd->process->pasid);
+ pr_debug_ratelimited("Restoring PASID 0x%x queues\n",
+ pdd->process->pasid);
/* Update PD Base in QPD */
qpd->page_table_base = pd_base;
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-02 0:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-01 23:11 [PATCH] drm/amdkfd: Make process queues logs less verbose Julian Sax
2020-02-01 23:37 ` Joe Perches
2020-02-02 0:14 ` Julian Sax
2020-02-02 0:18 ` [PATCH v2] " Julian Sax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox