* [PATCH] xhci: fix typo in babble endpoint handling comment
@ 2016-03-11 4:57 Rajesh Bhagat
2016-03-11 6:54 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Rajesh Bhagat @ 2016-03-11 4:57 UTC (permalink / raw)
To: linux-usb, linux-kernel; +Cc: mathias.nyman, gregkh, Rajesh Bhagat
The 0.95 xHCI spec says that non-control endpoints will be halted if a
babble is detected on a transfer. The 0.96 xHCI spec says all types of
endpoints will be halted when a babble is detected. Some hardware that
claims to be 0.95 compliant halts the control endpoint anyway.
Reference: http://www.spinics.net/lists/linux-usb/msg21755.html
Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 3915657..59841a9 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -1768,7 +1768,7 @@ static int xhci_requires_manual_halt_cleanup(struct xhci_hcd *xhci,
if (trb_comp_code == COMP_TX_ERR ||
trb_comp_code == COMP_BABBLE ||
trb_comp_code == COMP_SPLIT_ERR)
- /* The 0.96 spec says a babbling control endpoint
+ /* The 0.95 spec says a babbling control endpoint
* is not halted. The 0.96 spec says it is. Some HW
* claims to be 0.95 compliant, but it halts the control
* endpoint anyway. Check if a babble halted the
--
2.6.2.198.g614a2ac
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xhci: fix typo in babble endpoint handling comment
2016-03-11 4:57 [PATCH] xhci: fix typo in babble endpoint handling comment Rajesh Bhagat
@ 2016-03-11 6:54 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2016-03-11 6:54 UTC (permalink / raw)
To: Rajesh Bhagat, linux-usb, linux-kernel
Cc: mathias.nyman, gregkh, Rajesh Bhagat
[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]
Rajesh Bhagat <rajesh.bhagat@nxp.com> writes:
> [ text/plain ]
> The 0.95 xHCI spec says that non-control endpoints will be halted if a
> babble is detected on a transfer. The 0.96 xHCI spec says all types of
> endpoints will be halted when a babble is detected. Some hardware that
> claims to be 0.95 compliant halts the control endpoint anyway.
>
> Reference: http://www.spinics.net/lists/linux-usb/msg21755.html
>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
Reviewed-by: Felipe Balbi <balbi@kernel.org>
> ---
> drivers/usb/host/xhci-ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 3915657..59841a9 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1768,7 +1768,7 @@ static int xhci_requires_manual_halt_cleanup(struct xhci_hcd *xhci,
> if (trb_comp_code == COMP_TX_ERR ||
> trb_comp_code == COMP_BABBLE ||
> trb_comp_code == COMP_SPLIT_ERR)
> - /* The 0.96 spec says a babbling control endpoint
> + /* The 0.95 spec says a babbling control endpoint
> * is not halted. The 0.96 spec says it is. Some HW
> * claims to be 0.95 compliant, but it halts the control
> * endpoint anyway. Check if a babble halted the
> --
> 2.6.2.198.g614a2ac
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-11 6:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-11 4:57 [PATCH] xhci: fix typo in babble endpoint handling comment Rajesh Bhagat
2016-03-11 6:54 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox