[PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

[PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

[Arseniy Krasnov]

'cs' here must in range [0:nanddev_ntargets).

Cc: stable@vger.kernel.org
Fixes: 32813e288414 ("mtd: rawnand: Get rid of chip->numchips")
Signed-off-by: Arseniy Krasnov <avkrasnov@rulkc.org>
---
 drivers/mtd/nand/raw/nand_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 13e4060bd1b6a..edfee22f15a73 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -174,7 +174,7 @@ void nand_select_target(struct nand_chip *chip, unsigned int cs)
 	 * cs should always lie between 0 and nanddev_ntargets(), when that's
 	 * not the case it's a bug and the caller should be fixed.
 	 */
-	if (WARN_ON(cs > nanddev_ntargets(&chip->base)))
+	if (WARN_ON(cs >= nanddev_ntargets(&chip->base)))
 		return;
 
 	chip->cur_cs = cs;
-- 
2.47.3

Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

[Miquel Raynal]

Hi,

On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:

Two important typos in the commit log :-)

> 'cs' here must in range [0:nanddev_ntargets).

                be                           [

Thanks,
Miquèl

Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

[Arseniy Krasnov]

05.05.2026 10:50, Miquel Raynal wrote:
> Hi,
>
> On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>
> Two important typos in the commit log :-)
>
>> 'cs' here must in range [0:nanddev_ntargets).
>                 be                           [


Hi, sorry, You mean?


'cs' here must be in range [0:nanddev_ntargets]. 


Thanks


>
> Thanks,
> Miquèl

Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

[Miquel Raynal]

On 05/05/2026 at 10:59:16 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:

> 05.05.2026 10:50, Miquel Raynal wrote:
>> Hi,
>>
>> On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>>
>> Two important typos in the commit log :-)
>>
>>> 'cs' here must in range [0:nanddev_ntargets).
>>                 be                           [
>
>
> Hi, sorry, You mean?
>
>
> 'cs' here must be in range [0:nanddev_ntargets]. 

I meant [0:nanddev_ntargets[ which is the mathematical way, IIRC, to
indicate that the last value is out of scope/excluded.

[0:nanddev_ntargets] means that nanddev_ntargets is included in the
scope of values and here since you are explicitly showing that it is
not, it feels wrong to use that convention.

Thanks,
Miquèl

Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

[Arseniy Krasnov]

05.05.2026 11:10, Miquel Raynal wrote:
> On 05/05/2026 at 10:59:16 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>
>> 05.05.2026 10:50, Miquel Raynal wrote:
>>> Hi,
>>>
>>> On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>>>
>>> Two important typos in the commit log :-)
>>>
>>>> 'cs' here must in range [0:nanddev_ntargets).
>>>                 be                           [
>>
>> Hi, sorry, You mean?
>>
>>
>> 'cs' here must be in range [0:nanddev_ntargets]. 
> I meant [0:nanddev_ntargets[ which is the mathematical way, IIRC, to
> indicate that the last value is out of scope/excluded.
>
> [0:nanddev_ntargets] means that nanddev_ntargets is included in the
> scope of values and here since you are explicitly showing that it is
> not, it feels wrong to use that convention.


Ahh, Yes I see, just small misunderstood in math symbols:

I mean: [A:B) == [A:B[

https://wikimedia.org/api/rest_v1/media/math/render/svg/0719b1b08cdf649e735e6dab6dc7355fa37a9b21

Ok, I'll update it!

Thanks!

>
> Thanks,
> Miquèl

Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

[Miquel Raynal]

On 05/05/2026 at 11:14:25 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:

> 05.05.2026 11:10, Miquel Raynal wrote:
>> On 05/05/2026 at 10:59:16 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>>
>>> 05.05.2026 10:50, Miquel Raynal wrote:
>>>> Hi,
>>>>
>>>> On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>>>>
>>>> Two important typos in the commit log :-)
>>>>
>>>>> 'cs' here must in range [0:nanddev_ntargets).
>>>>                 be                           [
>>>
>>> Hi, sorry, You mean?
>>>
>>>
>>> 'cs' here must be in range [0:nanddev_ntargets]. 
>> I meant [0:nanddev_ntargets[ which is the mathematical way, IIRC, to
>> indicate that the last value is out of scope/excluded.
>>
>> [0:nanddev_ntargets] means that nanddev_ntargets is included in the
>> scope of values and here since you are explicitly showing that it is
>> not, it feels wrong to use that convention.
>
>
> Ahh, Yes I see, just small misunderstood in math symbols:
>
> I mean: [A:B) == [A:B[
>
> https://wikimedia.org/api/rest_v1/media/math/render/svg/0719b1b08cdf649e735e6dab6dc7355fa37a9b21

Ah ok, didn't know that other convention, fine then, take the one you prefer if
both are identical. Just add the missing "be" please!

Thanks,
Miquèl

Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'

[Arseniy Krasnov]

05.05.2026 11:23, Miquel Raynal wrote:
> On 05/05/2026 at 11:14:25 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>
>> 05.05.2026 11:10, Miquel Raynal wrote:
>>> On 05/05/2026 at 10:59:16 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>>>
>>>> 05.05.2026 10:50, Miquel Raynal wrote:
>>>>> Hi,
>>>>>
>>>>> On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>>>>>
>>>>> Two important typos in the commit log :-)
>>>>>
>>>>>> 'cs' here must in range [0:nanddev_ntargets).
>>>>>                 be                           [
>>>> Hi, sorry, You mean?
>>>>
>>>>
>>>> 'cs' here must be in range [0:nanddev_ntargets]. 
>>> I meant [0:nanddev_ntargets[ which is the mathematical way, IIRC, to
>>> indicate that the last value is out of scope/excluded.
>>>
>>> [0:nanddev_ntargets] means that nanddev_ntargets is included in the
>>> scope of values and here since you are explicitly showing that it is
>>> not, it feels wrong to use that convention.
>>
>> Ahh, Yes I see, just small misunderstood in math symbols:
>>
>> I mean: [A:B) == [A:B[
>>
>> https://wikimedia.org/api/rest_v1/media/math/render/svg/0719b1b08cdf649e735e6dab6dc7355fa37a9b21
> Ah ok, didn't know that other convention, fine then, take the one you prefer if
> both are identical. Just add the missing "be" please!

Sure!

Thanks, Arseniy


>
> Thanks,
> Miquèl