[PATCH] bus: ac97: clean up whitespace and move EXPORT_SYMBOLs

[PATCH] bus: ac97: clean up whitespace and move EXPORT_SYMBOLs

[Lucas Poupeau]

Clean up an unnecessary space in a conditional statement and move
EXPORT_SYMBOL_GPL(snd_ac97_reset) and EXPORT_SYMBOL(ac97_bus_type)
to immediately follow their respective definitions.

This complies with the Linux kernel coding style convention which
prefers exports to be placed next to the exported symbol for better
code locality and readability.

Signed-off-by: Lucas Poupeau <lucasp.linux@gmail.com>
---
 sound/ac97_bus.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
index 8a44297964f5..ad7fb6b0c2c0 100644
--- a/sound/ac97_bus.c
+++ b/sound/ac97_bus.c
@@ -73,7 +73,6 @@ int snd_ac97_reset(struct snd_ac97 *ac97, bool try_warm, unsigned int id,
 
 	if (snd_ac97_check_id(ac97, id, id_mask))
 		return 0;
-
 	return -ENODEV;
 }
 EXPORT_SYMBOL_GPL(snd_ac97_reset);
@@ -81,6 +80,7 @@ EXPORT_SYMBOL_GPL(snd_ac97_reset);
 const struct bus_type ac97_bus_type = {
 	.name		= "ac97",
 };
+EXPORT_SYMBOL(ac97_bus_type);
 
 static int __init ac97_bus_init(void)
 {
@@ -96,7 +96,5 @@ static void __exit ac97_bus_exit(void)
 
 module_exit(ac97_bus_exit);
 
-EXPORT_SYMBOL(ac97_bus_type);
-
 MODULE_DESCRIPTION("Legacy AC97 bus interface");
 MODULE_LICENSE("GPL");
-- 
2.54.0

Re: [PATCH] bus: ac97: clean up whitespace and move EXPORT_SYMBOLs

[Takashi Iwai]

On Mon, 04 May 2026 17:38:31 +0200,
Lucas Poupeau wrote:
> 
> Clean up an unnecessary space in a conditional statement and move
> EXPORT_SYMBOL_GPL(snd_ac97_reset) and EXPORT_SYMBOL(ac97_bus_type)
> to immediately follow their respective definitions.
> 
> This complies with the Linux kernel coding style convention which
> prefers exports to be placed next to the exported symbol for better
> code locality and readability.
> 
> Signed-off-by: Lucas Poupeau <lucasp.linux@gmail.com>

Applied to for-next branch.  Thanks.


Takashi