public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Fredrick Prashanth John Berchmans <fredrickprashanth@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: nfs accesses of FAT fs folders causes deadlock on lock_super
Date: Wed, 05 May 2010 03:41:27 +0900	[thread overview]
Message-ID: <87mxwfy0fc.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <t2gd4f60c3c1005041101o5720e1e4k69b4a7b76296e70f@mail.gmail.com> (Fredrick Prashanth John Berchmans's message of "Tue, 4 May 2010 11:01:22 -0700")

Fredrick Prashanth John Berchmans <fredrickprashanth@gmail.com> writes:

> On Tue, May 4, 2010 at 3:32 AM, Christoph Hellwig <hch@infradead.org> wrote:
>> On Mon, May 03, 2010 at 10:59:42PM -0700, Fredrick Prashanth John Berchmans wrote:
>>> The box was running kernel version 2.6.27.10.
>>> But I think the FAT code has not changed much.
>>
>> But the nfsd code has and now doesn't call lookup from the filldir
>> callback anymore.
>>
>>
>
> I see from nfsd code, it seems the compose_entry_fh still calls
> lookup_one_len, which is now
> called from encode_entryplus_baggage instead of entry_encode.
> Am I right?

As far as I can see, nfsd is buffering the result of readdir, then do
jobs (encode_fh, etc.) with it on other context of readdir.

Aren't you missing a buffering of nfsd_buffered_readdir()?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2010-05-04 18:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04  5:59 nfs accesses of FAT fs folders causes deadlock on lock_super Fredrick Prashanth John Berchmans
2010-05-04 10:32 ` Christoph Hellwig
2010-05-04 14:05   ` Fredrick Prashanth John Berchmans
2010-05-04 18:37     ` OGAWA Hirofumi
2010-05-04 18:01   ` Fredrick Prashanth John Berchmans
2010-05-04 18:41     ` OGAWA Hirofumi [this message]
2010-05-04 19:43       ` Fredrick Prashanth John Berchmans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxwfy0fc.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=fredrickprashanth@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox