From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Fredrick Prashanth John Berchmans <fredrickprashanth@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: nfs accesses of FAT fs folders causes deadlock on lock_super
Date: Wed, 05 May 2010 03:37:56 +0900 [thread overview]
Message-ID: <87r5lry0l7.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <m2id4f60c3c1005040705v2e46547axad496769d4d4dbe8@mail.gmail.com> (Fredrick Prashanth John Berchmans's message of "Tue, 4 May 2010 07:05:34 -0700")
Fredrick Prashanth John Berchmans <fredrickprashanth@gmail.com> writes:
> On Tue, May 4, 2010 at 3:32 AM, Christoph Hellwig <hch@infradead.org> wrote:
>> On Mon, May 03, 2010 at 10:59:42PM -0700, Fredrick Prashanth John Berchmans wrote:
>>> The box was running kernel version 2.6.27.10.
>>> But I think the FAT code has not changed much.
>>
>> But the nfsd code has and now doesn't call lookup from the filldir
>> callback anymore.
>>
>>
>
> Ah..I just noticed the changes in the nfsd code.
>
> But in 2.6.27.10, can it be fixed by removing the lock_super in the
> vfat_lookup.?
Basically, yes.
> Because I saw some discussions long back of regressions due to
> replacing lock_kernel by lock_super in FAT code.
Yes. Current way is ultra safer side to convert BKL. Another side was
just to remove BKL. However, at least for now, we are using current way.
So, if current way had a problem, just remove it instead of trying to
fix (then, review).
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2010-05-04 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 5:59 nfs accesses of FAT fs folders causes deadlock on lock_super Fredrick Prashanth John Berchmans
2010-05-04 10:32 ` Christoph Hellwig
2010-05-04 14:05 ` Fredrick Prashanth John Berchmans
2010-05-04 18:37 ` OGAWA Hirofumi [this message]
2010-05-04 18:01 ` Fredrick Prashanth John Berchmans
2010-05-04 18:41 ` OGAWA Hirofumi
2010-05-04 19:43 ` Fredrick Prashanth John Berchmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5lry0l7.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=fredrickprashanth@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox