public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: ye.xingchen@zte.com.cn
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] genirq: Fix parameter type in declaration and definition
Date: Thu, 13 Mar 2025 12:31:47 +0100	[thread overview]
Message-ID: <87o6y55fq4.ffs@tglx> (raw)
In-Reply-To: <20250313161803777QVS2cRAMUHinpoDwqg1XZ@zte.com.cn>

On Thu, Mar 13 2025 at 16:18, ye xingchen wrote:

$Subject: ... Fix ...

There is nothing to fix here. It's correct code.

> This patch aligns the parameter name in the definition with the

See other reply.

> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
>   *	interrupt controller has per-cpu registers.
>   */
>  int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
> -			  bool val)
> +			  bool state)

Now the kernel doc of that function is inconsistent.

You are not making anything more consistent, you are actively making it
worse. Please stop sending half thought out patches every half an hour.

Thanks,

        tglx




  reply	other threads:[~2025-03-13 11:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13  8:18 [PATCH v3] genirq: Fix parameter type in declaration and definition ye.xingchen
2025-03-13 11:31 ` Thomas Gleixner [this message]
2025-03-17 13:30   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6y55fq4.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ye.xingchen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox