[PATCH v3] genirq: Fix parameter type in declaration and definition

[PATCH v3] genirq: Fix parameter type in declaration and definition

[ye.xingchen]

From: YeXingchen <ye.xingchen@zte.com.cn>

The declaration of irq_set_irqchip_state in the header file uses
bool state as the parameter type, while the definition uses bool val.

This patch aligns the parameter name in the definition with the
declaration,changing val to state to ensure consistency.

Signed-off-by: YeXingchen <ye.xingchen@zte.com.cn>
---
v1->v3
fix the patch and patameter
 kernel/irq/manage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index f300bb6be3bd..3008f14f4db2 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
  *	interrupt controller has per-cpu registers.
  */
 int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
-			  bool val)
+			  bool state)
 {
 	struct irq_desc *desc;
 	struct irq_data *data;
@@ -2890,7 +2890,7 @@ int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
 	} while (data);

 	if (data)
-		err = chip->irq_set_irqchip_state(data, which, val);
+		err = chip->irq_set_irqchip_state(data, which, state);

 out_unlock:
 	irq_put_desc_busunlock(desc, flags);
-- 
2.25.1

Re: [PATCH v3] genirq: Fix parameter type in declaration and definition

[Thomas Gleixner]

On Thu, Mar 13 2025 at 16:18, ye xingchen wrote:

$Subject: ... Fix ...

There is nothing to fix here. It's correct code.

> This patch aligns the parameter name in the definition with the

See other reply.

> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
>   *	interrupt controller has per-cpu registers.
>   */
>  int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
> -			  bool val)
> +			  bool state)

Now the kernel doc of that function is inconsistent.

You are not making anything more consistent, you are actively making it
worse. Please stop sending half thought out patches every half an hour.

Thanks,

        tglx

Re: [PATCH v3] genirq: Fix parameter type in declaration and definition

[Krzysztof Kozlowski]

On 13/03/2025 12:31, Thomas Gleixner wrote:
> On Thu, Mar 13 2025 at 16:18, ye xingchen wrote:
> 
> $Subject: ... Fix ...
> 
> There is nothing to fix here. It's correct code.
> 
>> This patch aligns the parameter name in the definition with the
> 
> See other reply.
Just FYI, as you noticed earlier version of this patch was not even
compiled and it is a pattern for ye.xingchen@zte.com.cn:

https://lore.kernel.org/all/20250313160959132rMOoPpNjSNTlB-E6rMOuj@zte.com.cn/

I would not trust any future version here.

Best regards,
Krzysztof