The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx
@ 2026-07-09 21:43 Sven Jans
  2026-07-15 14:34 ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Sven Jans @ 2026-07-09 21:43 UTC (permalink / raw)
  Cc: Sven Jans, David Rhodes, Richard Fitzgerald, Jaroslav Kysela,
	Takashi Iwai, linux-sound, patches, linux-kernel

The laptop has a malformed _DSD which causes the cirrus,dev-index
property to fail to parse, so it needs to be supported using the
configuration table.

Signed-off-by: Sven Jans <skbotnl@disroot.org>
---
Resubmission, discussion of the previous submission stalled.
The values are equal to the values reported in the _DSD.
You can find my ACPI dump to verify here:
https://bugzilla.kernel.org/attachment.cgi?id=310050
Link to v1:
https://lore.kernel.org/linux-sound/20260506181807.22547-1-skbotnl@disroot.org/

 sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
index 416d7bf3e289..e14a87336478 100644
--- a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
+++ b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
@@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
+	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -511,6 +512,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
 	{ "CSC3551", "103C8CDD", generic_dsd_config },
 	{ "CSC3551", "103C8CDE", generic_dsd_config },
+	{ "CSC3551", "103C8E60", generic_dsd_config },
 	{ "CSC3551", "104312AF", generic_dsd_config },
 	{ "CSC3551", "10431433", generic_dsd_config },
 	{ "CSC3551", "10431463", generic_dsd_config },
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx
  2026-07-09 21:43 [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx Sven Jans
@ 2026-07-15 14:34 ` Takashi Iwai
  2026-07-15 14:54   ` Sven Jans
  2026-07-15 16:13   ` Stefan Binding (Opensource)
  0 siblings, 2 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-07-15 14:34 UTC (permalink / raw)
  To: Stefan Binding
  Cc: Sven Jans, David Rhodes, Richard Fitzgerald, Jaroslav Kysela,
	Takashi Iwai, linux-sound, patches, linux-kernel

On Thu, 09 Jul 2026 23:43:53 +0200,
Sven Jans wrote:
> 
> The laptop has a malformed _DSD which causes the cirrus,dev-index
> property to fail to parse, so it needs to be supported using the
> configuration table.
> 
> Signed-off-by: Sven Jans <skbotnl@disroot.org>
> ---
> Resubmission, discussion of the previous submission stalled.
> The values are equal to the values reported in the _DSD.
> You can find my ACPI dump to verify here:
> https://bugzilla.kernel.org/attachment.cgi?id=310050
> Link to v1:
> https://lore.kernel.org/linux-sound/20260506181807.22547-1-skbotnl@disroot.org/

Stefan, is this also one of models with odd firmware?


thanks,

Takashi

> 
>  sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> index 416d7bf3e289..e14a87336478 100644
> --- a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> +++ b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> @@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
>  	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
>  	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
>  	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
> +	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
>  	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
>  	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
>  	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> @@ -511,6 +512,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
>  	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
>  	{ "CSC3551", "103C8CDD", generic_dsd_config },
>  	{ "CSC3551", "103C8CDE", generic_dsd_config },
> +	{ "CSC3551", "103C8E60", generic_dsd_config },
>  	{ "CSC3551", "104312AF", generic_dsd_config },
>  	{ "CSC3551", "10431433", generic_dsd_config },
>  	{ "CSC3551", "10431463", generic_dsd_config },
> -- 
> 2.55.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx
  2026-07-15 14:34 ` Takashi Iwai
@ 2026-07-15 14:54   ` Sven Jans
  2026-07-15 16:13   ` Stefan Binding (Opensource)
  1 sibling, 0 replies; 4+ messages in thread
From: Sven Jans @ 2026-07-15 14:54 UTC (permalink / raw)
  To: Takashi Iwai, Stefan Binding
  Cc: David Rhodes, Richard Fitzgerald, Jaroslav Kysela, Takashi Iwai,
	linux-sound, patches, linux-kernel

For what it's worth Stefan has confirmed that there is an issue with 
this laptop here: https://bugzilla.kernel.org/show_bug.cgi?id=221185#c11
The mentioned bug report 221479 is mine 
(https://bugzilla.kernel.org/show_bug.cgi?id=221479).

On 15/07/2026 16:34, Takashi Iwai wrote:
> On Thu, 09 Jul 2026 23:43:53 +0200,
> Sven Jans wrote:
>>
>> The laptop has a malformed _DSD which causes the cirrus,dev-index
>> property to fail to parse, so it needs to be supported using the
>> configuration table.
>>
>> Signed-off-by: Sven Jans <skbotnl@disroot.org>
>> ---
>> Resubmission, discussion of the previous submission stalled.
>> The values are equal to the values reported in the _DSD.
>> You can find my ACPI dump to verify here:
>> https://bugzilla.kernel.org/attachment.cgi?id=310050
>> Link to v1:
>> https://lore.kernel.org/linux-sound/20260506181807.22547-1-skbotnl@disroot.org/
> 
> Stefan, is this also one of models with odd firmware?
> 
> 
> thanks,
> 
> Takashi
> 
>>
>>   sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
>> index 416d7bf3e289..e14a87336478 100644
>> --- a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
>> +++ b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
>> @@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
>>   	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
>>   	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
>>   	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
>> +	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
>>   	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
>>   	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
>>   	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
>> @@ -511,6 +512,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
>>   	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
>>   	{ "CSC3551", "103C8CDD", generic_dsd_config },
>>   	{ "CSC3551", "103C8CDE", generic_dsd_config },
>> +	{ "CSC3551", "103C8E60", generic_dsd_config },
>>   	{ "CSC3551", "104312AF", generic_dsd_config },
>>   	{ "CSC3551", "10431433", generic_dsd_config },
>>   	{ "CSC3551", "10431463", generic_dsd_config },
>> -- 
>> 2.55.0
>>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx
  2026-07-15 14:34 ` Takashi Iwai
  2026-07-15 14:54   ` Sven Jans
@ 2026-07-15 16:13   ` Stefan Binding (Opensource)
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Binding (Opensource) @ 2026-07-15 16:13 UTC (permalink / raw)
  To: 'Takashi Iwai'
  Cc: 'Sven Jans', 'David Rhodes',
	'Richard Fitzgerald', 'Jaroslav Kysela',
	'Takashi Iwai', linux-sound, patches, linux-kernel

Hi Takashi,

Yes, this is one of the laptops with malformed ACPI.

Thanks,
Stefan

> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Wednesday, July 15, 2026 3:35 PM
> To: Stefan Binding <sbinding@opensource.cirrus.com>
> Cc: Sven Jans <skbotnl@disroot.org>; David Rhodes
> <david.rhodes@cirrus.com>; Richard Fitzgerald <rf@opensource.cirrus.com>;
> Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; linux-
> sound@vger.kernel.org; patches@opensource.cirrus.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop
> 16-bh0xxx
> 
> On Thu, 09 Jul 2026 23:43:53 +0200,
> Sven Jans wrote:
> >
> > The laptop has a malformed _DSD which causes the cirrus,dev-index
> > property to fail to parse, so it needs to be supported using the
> > configuration table.
> >
> > Signed-off-by: Sven Jans <skbotnl@disroot.org>
> > ---
> > Resubmission, discussion of the previous submission stalled.
> > The values are equal to the values reported in the _DSD.
> > You can find my ACPI dump to verify here:
> > https://bugzilla.kernel.org/attachment.cgi?id=310050
> > Link to v1:
> > https://lore.kernel.org/linux-sound/20260506181807.22547-1-
> skbotnl@dis
> > root.org/
> 
> Stefan, is this also one of models with odd firmware?
> 
> 
> thanks,
> 
> Takashi
> 
> >
> >  sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> > b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> > index 416d7bf3e289..e14a87336478 100644
> > --- a/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> > +++ b/sound/hda/codecs/side-codecs/cs35l41_hda_property.c
> > @@ -85,6 +85,7 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
> >  	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 1000, 4100, 24 },
> >  	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 1000, 4100, 24 },
> >  	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0,
> > 1, -1, 1000, 3900, 24 },
> > +	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0,
> > +1, -1, 1000, 4500, 24 },
> >  	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 1, 2, 0, 1000, 4500, 24 },
> >  	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 1000, 4500, 24 },
> >  	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0,
> > 1, -1, 1000, 4500, 24 }, @@ -511,6 +512,7 @@ static const struct
> cs35l41_prop_model cs35l41_prop_model_table[] = {
> >  	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
> >  	{ "CSC3551", "103C8CDD", generic_dsd_config },
> >  	{ "CSC3551", "103C8CDE", generic_dsd_config },
> > +	{ "CSC3551", "103C8E60", generic_dsd_config },
> >  	{ "CSC3551", "104312AF", generic_dsd_config },
> >  	{ "CSC3551", "10431433", generic_dsd_config },
> >  	{ "CSC3551", "10431463", generic_dsd_config },
> > --
> > 2.55.0
> >


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-07-15 16:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-09 21:43 [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx Sven Jans
2026-07-15 14:34 ` Takashi Iwai
2026-07-15 14:54   ` Sven Jans
2026-07-15 16:13   ` Stefan Binding (Opensource)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox