The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: fffsqian@163.com, jhogan@kernel.org
Cc: linux-kernel@vger.kernel.org, Qingshuang Fu <fuqingshuang@kylinos.cn>
Subject: Re: [PATCH 1/1] irqchip/imgpdc: fix generic IRQ chip leak and missing chained handler cleanup on remove
Date: Wed, 17 Jun 2026 18:14:36 +0200	[thread overview]
Message-ID: <87pl1pcff7.ffs@fw13> (raw)
In-Reply-To: <20260612084744.1219349-1-fffsqian@163.com>

On Fri, Jun 12 2026 at 16:47, fffsqian@163.com wrote:
> @@ -457,6 +457,7 @@ static int pdc_intc_probe(struct platform_device *pdev)
>  
>  	return 0;
>  err_generic:
> +	irq_domain_remove_generic_chips(priv->domain);

You can spare this call and the one below by setting
IRQ_DOMAIN_FLAG_DESTROY_GC in domain->flags. Then the core will remove
the chip when mopping up the domain.

>  	irq_domain_remove(priv->domain);
>  	return ret;
>  }
> @@ -464,7 +465,14 @@ static int pdc_intc_probe(struct platform_device *pdev)
>  static void pdc_intc_remove(struct platform_device *pdev)
>  {
>  	struct pdc_intc_priv *priv = platform_get_drvdata(pdev);
> +	unsigned int i;
> +
> +	for (i = 0; i < priv->nr_perips; ++i)

  for (unsigned int i = 0;

Thanks,

        tglx

      reply	other threads:[~2026-06-17 16:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12  8:47 [PATCH 1/1] irqchip/imgpdc: fix generic IRQ chip leak and missing chained handler cleanup on remove fffsqian
2026-06-17 16:14 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl1pcff7.ffs@fw13 \
    --to=tglx@kernel.org \
    --cc=fffsqian@163.com \
    --cc=fuqingshuang@kylinos.cn \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox