From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource
Date: Sun, 07 Feb 2016 12:47:18 +0100 [thread overview]
Message-ID: <87pow83fp5.fsf@belgarion.home> (raw)
In-Reply-To: <56B72133.5090801@cogentembedded.com> (Sergei Shtylyov's message of "Sun, 7 Feb 2016 13:49:23 +0300")
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:
>> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse
>
> Fixes: tag here?
Heuh no. It doesn't fix this commit, it uses a feature brought by this commit.
>> + if (irq_get_trigger_type(dev->irq) == IRQF_TRIGGER_NONE)
>> dev_warn(db->dev, "WARNING: no IRQ resource flags set.\n");
>>
>> irqflags |= IRQF_SHARED;
>
> Why not just initialize to IRQF_SHARED?
> But actually you don't need this variable anymore.
Yeah, makes sense.
Cheers.
--
Robert
prev parent reply other threads:[~2016-02-07 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 22:11 [PATCH v2] net: ethernet: davicom: fix devicetree irq resource Robert Jarzmik
2016-02-07 10:23 ` Francois Romieu
2016-02-07 10:46 ` Robert Jarzmik
2016-02-07 12:34 ` Francois Romieu
2016-02-07 10:49 ` Sergei Shtylyov
2016-02-07 11:47 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pow83fp5.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox