[PATCH V2] ALSA: usb-audio: US16x08: Initialize array before use

[PATCH V2] ALSA: usb-audio: US16x08: Initialize array before use

[Tanya Agarwal]

From: Tanya Agarwal <tanyaagarwal25699@gmail.com>

Initialize meter_urb array before use in mixer_us16x08.c.

CID 1410197: (#1 of 1): Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value *meter_urb when
calling get_meter_levels_from_urb.

Coverity Link:
https://scan7.scan.coverity.com/#/project-view/52849/11354?selectedIssue=1410197

Fixes: d2bb390a2081 ("ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk")
Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
---
Changes in V2:
- Updated commit text
- Link to V1: https://lore.kernel.org/all/20241228070317.2956-1-tanyaagarwal25699@gmail.com
---
 sound/usb/mixer_us16x08.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
index 6eb7d93b358d..20ac32635f1f 100644
--- a/sound/usb/mixer_us16x08.c
+++ b/sound/usb/mixer_us16x08.c
@@ -687,7 +687,7 @@ static int snd_us16x08_meter_get(struct snd_kcontrol *kcontrol,
 	struct usb_mixer_elem_info *elem = kcontrol->private_data;
 	struct snd_usb_audio *chip = elem->head.mixer->chip;
 	struct snd_us16x08_meter_store *store = elem->private_data;
-	u8 meter_urb[64];
+	u8 meter_urb[64] = {0};
 
 	switch (kcontrol->private_value) {
 	case 0: {
-- 
2.39.5

Re: [PATCH V2] ALSA: usb-audio: US16x08: Initialize array before use

[Takashi Iwai]

On Sun, 29 Dec 2024 07:02:42 +0100,
Tanya Agarwal wrote:
> 
> From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> 
> Initialize meter_urb array before use in mixer_us16x08.c.
> 
> CID 1410197: (#1 of 1): Uninitialized scalar variable (UNINIT)
> uninit_use_in_call: Using uninitialized value *meter_urb when
> calling get_meter_levels_from_urb.
> 
> Coverity Link:
> https://scan7.scan.coverity.com/#/project-view/52849/11354?selectedIssue=1410197
> 
> Fixes: d2bb390a2081 ("ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk")
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>

Applied now.  Thanks.


Takashi

Re: [PATCH V2] ALSA: usb-audio: US16x08: Initialize array before use

[Tanya Agarwal]

On Sun, Dec 29, 2024 at 1:57 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Sun, 29 Dec 2024 07:02:42 +0100,
> Tanya Agarwal wrote:
> >
> > From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> >
> > Initialize meter_urb array before use in mixer_us16x08.c.
> >
> > CID 1410197: (#1 of 1): Uninitialized scalar variable (UNINIT)
> > uninit_use_in_call: Using uninitialized value *meter_urb when
> > calling get_meter_levels_from_urb.
> >
> > Coverity Link:
> > https://scan7.scan.coverity.com/#/project-view/52849/11354?selectedIssue=1410197
> >
> > Fixes: d2bb390a2081 ("ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk")
> > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
>
> Applied now.  Thanks.


Thanks, Takashi.

Regards,
Tanya