* [PATCH] ALSA: hda: cs35l41: Fix NULL pointer dereference in cs35l41_hda_read_acpi()
@ 2025-12-02 10:13 Denis Arefev
2025-12-04 11:00 ` Richard Fitzgerald
2025-12-05 14:13 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Denis Arefev @ 2025-12-02 10:13 UTC (permalink / raw)
To: David Rhodes
Cc: Richard Fitzgerald, Jaroslav Kysela, Takashi Iwai, Stefan Binding,
linux-sound, patches, linux-kernel, lvc-project, stable
The acpi_get_first_physical_node() function can return NULL, in which
case the get_device() function also returns NULL, but this value is
then dereferenced without checking,so add a check to prevent a crash.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 7b2f3eb492da ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems")
Cc: stable@vger.kernel.org
Signed-off-by: Denis Arefev <arefev@swemel.ru>
---
sound/hda/codecs/side-codecs/cs35l41_hda.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/hda/codecs/side-codecs/cs35l41_hda.c b/sound/hda/codecs/side-codecs/cs35l41_hda.c
index c0f2a3ff77a1..21e00055c0c4 100644
--- a/sound/hda/codecs/side-codecs/cs35l41_hda.c
+++ b/sound/hda/codecs/side-codecs/cs35l41_hda.c
@@ -1901,6 +1901,8 @@ static int cs35l41_hda_read_acpi(struct cs35l41_hda *cs35l41, const char *hid, i
cs35l41->dacpi = adev;
physdev = get_device(acpi_get_first_physical_node(adev));
+ if (!physdev)
+ return -ENODEV;
sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));
if (IS_ERR(sub))
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: hda: cs35l41: Fix NULL pointer dereference in cs35l41_hda_read_acpi()
2025-12-02 10:13 [PATCH] ALSA: hda: cs35l41: Fix NULL pointer dereference in cs35l41_hda_read_acpi() Denis Arefev
@ 2025-12-04 11:00 ` Richard Fitzgerald
2025-12-05 14:13 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Richard Fitzgerald @ 2025-12-04 11:00 UTC (permalink / raw)
To: Denis Arefev, David Rhodes
Cc: Jaroslav Kysela, Takashi Iwai, Stefan Binding, linux-sound,
patches, linux-kernel, lvc-project, stable
On 02/12/2025 10:13 am, Denis Arefev wrote:
> The acpi_get_first_physical_node() function can return NULL, in which
> case the get_device() function also returns NULL, but this value is
> then dereferenced without checking,so add a check to prevent a crash.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 7b2f3eb492da ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems")
> Cc: stable@vger.kernel.org
> Signed-off-by: Denis Arefev <arefev@swemel.ru>
> ---
> sound/hda/codecs/side-codecs/cs35l41_hda.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/hda/codecs/side-codecs/cs35l41_hda.c b/sound/hda/codecs/side-codecs/cs35l41_hda.c
> index c0f2a3ff77a1..21e00055c0c4 100644
> --- a/sound/hda/codecs/side-codecs/cs35l41_hda.c
> +++ b/sound/hda/codecs/side-codecs/cs35l41_hda.c
> @@ -1901,6 +1901,8 @@ static int cs35l41_hda_read_acpi(struct cs35l41_hda *cs35l41, const char *hid, i
>
> cs35l41->dacpi = adev;
> physdev = get_device(acpi_get_first_physical_node(adev));
> + if (!physdev)
> + return -ENODEV;
>
> sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));
> if (IS_ERR(sub))
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: hda: cs35l41: Fix NULL pointer dereference in cs35l41_hda_read_acpi()
2025-12-02 10:13 [PATCH] ALSA: hda: cs35l41: Fix NULL pointer dereference in cs35l41_hda_read_acpi() Denis Arefev
2025-12-04 11:00 ` Richard Fitzgerald
@ 2025-12-05 14:13 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2025-12-05 14:13 UTC (permalink / raw)
To: Denis Arefev
Cc: David Rhodes, Richard Fitzgerald, Jaroslav Kysela, Takashi Iwai,
Stefan Binding, linux-sound, patches, linux-kernel, lvc-project,
stable
On Tue, 02 Dec 2025 11:13:36 +0100,
Denis Arefev wrote:
>
> The acpi_get_first_physical_node() function can return NULL, in which
> case the get_device() function also returns NULL, but this value is
> then dereferenced without checking,so add a check to prevent a crash.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 7b2f3eb492da ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems")
> Cc: stable@vger.kernel.org
> Signed-off-by: Denis Arefev <arefev@swemel.ru>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-05 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-02 10:13 [PATCH] ALSA: hda: cs35l41: Fix NULL pointer dereference in cs35l41_hda_read_acpi() Denis Arefev
2025-12-04 11:00 ` Richard Fitzgerald
2025-12-05 14:13 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox